Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddex typescript processor #8187

Merged
merged 23 commits into from
Apr 26, 2024
Merged

ddex typescript processor #8187

merged 23 commits into from
Apr 26, 2024

Conversation

stereosteve
Copy link
Contributor

@stereosteve stereosteve commented Apr 22, 2024

typescript + sqlite ddex processor.

* reprocess xml from db without any s3 or fs interaction
* release.problems col tracks reasons why release is not publishable
* defer reading of asset files until publish time
* track release uses image from main release as fallback
Copy link

changeset-bot bot commented Apr 22, 2024

⚠️ No Changeset found

Latest commit: f0e8b35

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

socket-security bot commented Apr 24, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/@apollo/protobufjs@1.2.7
  • Install script: postinstall
  • Source: node scripts/postinstall
  • orphan: npm/@apollo/protobufjs@1.2.7

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/@apollo/protobufjs@1.2.7

Copy link

socket-security bot commented Apr 26, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@amplitude/node@1.9.2 network +4 590 kB kevinpagtakhan
npm/@amplitude/react-native@2.17.2 None 0 187 kB hao.yu
npm/@apollo/client@3.3.7 environment, network Transitive: eval +1 3.3 MB apollo-bot
npm/@babel/cli@7.7.0 Transitive: environment, filesystem, unsafe +30 7.63 MB nicolo-ribaudo
npm/@babel/plugin-proposal-class-static-block@7.21.0 Transitive: environment, filesystem, unsafe +38 7.91 MB nicolo-ribaudo
npm/@babel/plugin-transform-react-jsx@7.21.0 Transitive: environment, filesystem, unsafe +33 7.69 MB nicolo-ribaudo
npm/@babel/plugin-transform-runtime@7.18.2 unsafe Transitive: environment, filesystem +31 7.62 MB nicolo-ribaudo
npm/@babel/preset-env@7.22.15 environment Transitive: filesystem, unsafe +115 9.65 MB nicolo-ribaudo
npm/@babel/preset-typescript@7.22.15 Transitive: environment, filesystem, unsafe +41 8.1 MB nicolo-ribaudo
npm/@babel/register@7.7.0 environment, filesystem Transitive: unsafe +30 7.6 MB nicolo-ribaudo
npm/@babel/runtime@7.18.3 None 0 201 kB nicolo-ribaudo
npm/@certusone/wormhole-sdk@0.1.1 filesystem Transitive: environment +2 15.2 MB evan-gray
npm/@changesets/cli@2.27.1 environment, filesystem, shell +25 1.4 MB changesets-release-bot

🚮 Removed packages: npm/@types/async-retry@1.4.5, npm/@types/fs-extra@9.0.13, npm/@types/node-fetch@2.6.2, npm/@types/node@18.11.9, npm/@types/prompt-sync@4.2.3, npm/axios@1.2.0, npm/fs-extra@11.0.0, npm/pg@8.8.0, npm/prompt-sync@4.2.0, npm/sequelize@6.25.8, npm/ts-node-dev@2.0.0, npm/ts-node@10.9.1, npm/typescript@4.9.3, npm/typescript@5.0.2, npm/web3@1.8.2

View full report↗︎

@stereosteve stereosteve changed the title ddex single proc ddex typescript processor Apr 26, 2024
@stereosteve stereosteve marked this pull request as ready for review April 26, 2024 15:58
@stereosteve stereosteve merged commit b36578f into main Apr 26, 2024
6 of 8 checks passed
@stereosteve stereosteve deleted the ddex-single-proc branch April 26, 2024 18:05
audius-infra pushed a commit that referenced this pull request Apr 29, 2024
[6eab8d7] [PROTO-1783] Finish entrypoint UI (#8246) Raymond Jacobson
[b36578f] ddex typescript processor (#8187) Steve Perkins
[baa9eb5] Use single bucket for ddex with simpler crawling (#8244) Theo Ilie
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants