Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index all memos (v1 and v2) and use cache in index_payment_router #8400

Merged
merged 1 commit into from
May 8, 2024
Merged

Index all memos (v1 and v2) and use cache in index_payment_router #8400

merged 1 commit into from
May 8, 2024

Conversation

rickyrombo
Copy link
Contributor

Description

Previously we ignored the Memo V2 Program. This allows us to parse those memos as well. Also adds support for loading from the cache for indexing payment router.

How Has This Been Tested?

Tested locally, purchased a track.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 8, 2024

⚠️ No Changeset found

Latest commit: 820a31a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rickyrombo rickyrombo merged commit a144f6a into main May 8, 2024
11 checks passed
@rickyrombo rickyrombo deleted the mjp-index-memos branch May 8, 2024 15:37
schottra
schottra reviewed May 8, 2024
View reviewed changes
packages/discovery-provider/src/solana/solana_helpers.py
@@ -39,5 +39,8 @@ def get_derived_address(base, hashed_eth_pk, spl_token_id):
# Static Memo Program ID
MEMO_PROGRAM_ID = "Memo1UhkJRfHyvLMcVucJwxXeuD728EqVDDwQDxFMNo"

# Static Memo Program ID
MEMO_V2_PROGRAM_ID = "MemoSq4gqABAXKb96qnH8TysNcWxMyWCqXgDLGmfcHr"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could have sworn that somewhere we were using memov2. But maybe that's just on the client side for Coinflow transactions.

audius-infra pushed a commit that referenced this pull request May 9, 2024
Audius Protocol v0.6.99
bc34a2c 
[a84cf8f] ddex: multi tenant (#8401) Steve Perkins
[a0e2033] Make indexer properly resort to using gateway if chain isn't caught up (#8397) Danny
[913c80b] DDEX users poller (#8380) Michelle Brier
[a144f6a] Index all memos (v1 and v2) and use cache in index_payment_router (#8400) Marcus Pasell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schottra schottra schottra left review comments

@raymondjacobson raymondjacobson raymondjacobson approved these changes

Assignees

@dharit-tan dharit-tan

@sddioulde sddioulde

@alecsavvy alecsavvy

Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rickyrombo @schottra @raymondjacobson @dharit-tan @sddioulde @alecsavvy