Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Users API #878

Merged
merged 7 commits into from
Oct 2, 2020
Merged

Full Users API #878

merged 7 commits into from
Oct 2, 2020

Conversation

raymondjacobson
Copy link
Member

@raymondjacobson raymondjacobson commented Oct 2, 2020

Trello Card Link

https://trello.com/c/A7BOsv5J/1476-port-the-new-api-into-the-dapp

Description

Add full API route handling for Users & User Tracks

Services

  • Discovery Provider

Does it touch a critical flow like Discovery indexing, Creator Node track upload, Creator Node gateway, or Creator Node file system?

Delete an option.

  • ✅ Nope

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Include log analysis if applicable.

  1. Manually on dapp, hitting new endpoints
  2. Ran discprov locally against prod data, hit all routes

discovery-provider/src/api/v1/users.py Outdated Show resolved Hide resolved
discovery-provider/src/api/v1/users.py Show resolved Hide resolved
discovery-provider/src/queries/get_tracks.py Outdated Show resolved Hide resolved
discovery-provider/src/utils/redis_cache.py Show resolved Hide resolved
discovery-provider/src/queries/get_users.py Show resolved Hide resolved
@raymondjacobson
Copy link
Member Author

Thx for comments. will rebase on your code & then get michael to review too

@raymondjacobson raymondjacobson merged commit 97bb6d3 into master Oct 2, 2020
@raymondjacobson raymondjacobson deleted the rj-users branch October 2, 2020 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants