Add nodesync export and sync integration tests #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piazzatron
force-pushed
the
piazz-sync-test
branch
from
2a8d54a
to
7812a44
Compare
dmanjunath
approved these changes
Oct 4, 2020
There was a problem hiding this comment.
This is going to be awesome to have @piazzatron. A few cleanup items but this looks dope
dmanjunath
approved these changes
Oct 5, 2020
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello Card Link
https://trello.com/c/64R0JpXW
Description
Adds two integration tests for nodesync:
Note this does not test the correctness of the file system post sync, though that codepath is lightly exercised (files are 'requested' from another CNode that is mocked to return buffers with garbage data).
Services
Does it touch a critical flow like Discovery indexing, Creator Node track upload, Creator Node gateway, or Creator Node file system?
How Has This Been Tested?
Added nodesync.test.js