SnapbackSM - Phase 0 (take 2) #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmanjunath
reviewed
Oct 6, 2020
dmanjunath
reviewed
Oct 6, 2020
hareeshnagaraj
commented
Oct 6, 2020
dmanjunath
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Fix for reverted PR - #815)
Trello Card Link
https://trello.com/c/g7NuhQwd/1543-snapbacksm-master
Description
In this PR, we add the
creatorNodeEndpointconfig to creator-node which enables spID verification from eth-contracts in addition to a disabled SnapbackSM skeleton class.Actual logic for
processStateMachineoperation will be filled in after this has been merged.SnapbackSM is added to the ServiceRegistry, initialized with libs, confirmed this does not affect base functionality
Services
Does it touch a critical flow like Discovery indexing, Creator Node track upload, Creator Node gateway, or Creator Node file system?
Delete an option.
How Has This Been Tested?
Unit test added to verify health check behavior with config parsing, no other default behavior modification so all other validation has been manual. Local setup + mad dog works in conjunction with tooling repo update