Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update playlist routes to support client #889

Merged
merged 3 commits into from
Oct 6, 2020
Merged

Conversation

raymondjacobson
Copy link
Member

@raymondjacobson raymondjacobson commented Oct 6, 2020

Trello Card Link

https://trello.com/c/A7BOsv5J/1476-port-the-new-api-into-the-dapp

Description

  • Cleans up a few missing fields in playlist response
  • Adds tracks to the playlist response in get single playlist & get user reposts

Services

  • Discovery Provider

Does it touch a critical flow like Discovery indexing, Creator Node track upload, Creator Node gateway, or Creator Node file system?

Delete an option.

  • ✅ Nope

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Include log analysis if applicable.

  1. Manually with the dapp against each route (profile page reposts

discovery-provider/src/api/v1/helpers.py Outdated Show resolved Hide resolved
@raymondjacobson raymondjacobson merged commit 6eaec0c into master Oct 6, 2020
@raymondjacobson raymondjacobson deleted the rj-playlist-fixes branch October 6, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants