SnapbackSM - Phase 1 - Recurring Sync #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hareeshnagaraj
commented
Oct 11, 2020
hareeshnagaraj
commented
Oct 11, 2020
creator-node/src/snapbackSM.js
Outdated
| // Run the task every x time interval | ||
| // */5 * * * *, every 5 minutes | ||
| // 0 * * * *, every hour at minute 0 | ||
| this.stateMachineQueue.add({}, { repeat: { cron: '0 * * * *' } }) |
There was a problem hiding this comment.
nice to have, switch cron to * */n * * * with n as a config hourInterval or smth per @dmanjunath
dmanjunath
reviewed
Oct 12, 2020
dmanjunath
reviewed
Oct 12, 2020
hareeshnagaraj
commented
Oct 12, 2020
hareeshnagaraj
commented
Oct 13, 2020
dmanjunath
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello Card Link
https://trello.com/c/g7NuhQwd/1543-snapbacksm-master
Description
Enable recurring sync operation separate from UserReplicaSetManager contract through SnapbackSM
Services
Does it touch a critical flow like Discovery indexing, Creator Node track upload, Creator Node gateway, or Creator Node file system?
No, but it has the potential to interfere with all of the above - so we must be very careful
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Include log analysis if applicable.
New mad dog test added to confirm sync progress, developer mode functionality for snapback, all unit tests for repo subcomponents passing as well