Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remixes and stems to API #893

Merged
merged 5 commits into from
Oct 8, 2020
Merged

Add remixes and stems to API #893

merged 5 commits into from
Oct 8, 2020

Conversation

piazzatron
Copy link
Contributor

@piazzatron piazzatron commented Oct 7, 2020

Trello Card Link

https://trello.com/c/A7BOsv5J

Description

Adds full endpoints:

  • tracks/id/stems
  • tracks/id/remixes
  • tracks/id/remixing

Also caught a bug in the tracks endpoint, where we were including the track users
inside the redis cache fn - they can't be inside because they're customized by current_user_id.

Services

  • Discovery Provider
  • Creator Node
  • Identity Service
  • Libs
  • Contracts
  • Service Commands
  • Mad Dog

Does it touch a critical flow like Discovery indexing, Creator Node track upload, Creator Node gateway, or Creator Node file system?

  • ✅ Nope

How Has This Been Tested?

Tested manually hitting endpoints.

discovery-provider/src/api/v1/helpers.py Show resolved Hide resolved
discovery-provider/src/utils/redis_cache.py Outdated Show resolved Hide resolved
@piazzatron piazzatron merged commit 78296e3 into master Oct 8, 2020
@piazzatron piazzatron deleted the piazz-remix-stems-api branch October 8, 2020 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants