Fix changes to search for deleted #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piazzatron
approved these changes
Oct 8, 2020
| @@ -72,7 +75,8 @@ def get_unpopulated_playlists(session, playlist_ids): | |||
| playlists_response = [] | |||
| for playlist_id in playlist_ids: | |||
| if playlist_id in cached_playlists: | |||
| playlists_response.append(cached_playlists[playlist_id]) | |||
| if not filter_deleted or not cached_playlists[playlist_id]['is_delete']: | |||
| playlists_response.append(cached_playlists[playlist_id]) | |||
There was a problem hiding this comment.
Does this mess up the ordering of our playlist response? Like if we request Ids [1, 2, 3] but 2 is deleted, now we're returning [Playlist1, Playlist3] and we don't know what corresponds to what? Or does order not matter?
There was a problem hiding this comment.
I use this in place of the actual query for tracks w/ these ids and the filter, so the same thing should happen that happened before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello Card Link
https://trello.com/c/A7BOsv5J/1476-port-the-new-api-into-the-dapp
Description
Addresses @piazzatron 's comments on #900
Services
Discovery Provider
Does it touch a critical flow like Discovery indexing, Creator Node track upload, Creator Node gateway, or Creator Node file system?
Delete an option.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Include log analysis if applicable.
I ran it against a prod db snapshot and and compared responses.