Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove config dep in updateContentBlacklist by extracting api signing #903

Merged
merged 5 commits into from
Oct 8, 2020

Conversation

vicky-g
Copy link
Contributor

@vicky-g vicky-g commented Oct 8, 2020

Trello Card Link

none

Description

Running updateContentBlacklist.js logs an error about a dep on config. This PR remove the config dep by extracting the api signing logic to another file.

Services

  • Discovery Provider
  • Creator Node
  • Identity Service
  • Libs
  • Contracts
  • Service Commands
  • Mad Dog

Does it touch a critical flow like Discovery indexing, Creator Node track upload, Creator Node gateway, or Creator Node file system?

  • 🚨 Yes, this touches ••Content Blacklist••

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Include log analysis if applicable.

  1. Run the script for a track in staging
  2. Check the associated creator nodes on staging that when hitting the route ipfs/<CID> an error like this appears:
{
  "error": "CID QmPLrsrZ8mGcAcabBWg8vBwCwLSzGGsbgvmk9u8yxKNk81 has been blacklisted by this node."
}

Please list the unit test(s) you added to verify your changes.

Copy link
Contributor

@dmanjunath dmanjunath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

creator-node/compose/env/base.env Show resolved Hide resolved
@vicky-g vicky-g merged commit 418e25b into master Oct 8, 2020
@vicky-g vicky-g deleted the vg-fix-content-bl-script branch October 8, 2020 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants