Fix track association so it only errors if files found < files expected #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o dm-fix-track-associate-hotfix
raymondjacobson
approved these changes
Oct 9, 2020
dmanjunath
commented
Oct 9, 2020
| @@ -313,8 +313,7 @@ module.exports = function (app) { | |||
| const existingTrackEntry = await models.Track.findOne({ | |||
| where: { | |||
| cnodeUserUUID, | |||
| blockchainId: blockchainTrackId, | |||
| coverArtFileUUID | |||
| blockchainId: blockchainTrackId | |||
There was a problem hiding this comment.
What was happening here is we were using the coverArtFileUUID for the existing track check which means if the cover art was changed, this check would fail and it would treat this as a new upload and fail because there were no unassociated files
dmanjunath
commented
Oct 9, 2020
| @@ -381,7 +380,8 @@ module.exports = function (app) { | |||
| transaction | |||
| }) | |||
|
|
|||
| if (trackFiles.length !== trackSegmentCIDs.length) { | |||
| if (trackFiles.length < trackSegmentCIDs.length) { | |||
There was a problem hiding this comment.
this also takes care of the case where a previous track_content left unassociated files. we'd error if the number of files is not exactly equal (so duplicates would break). this way we'll associate it all under this trackId. See https://github.com/AudiusProject/audius-protocol/blame/3bf6a8137ae25529583f21ac259562c712e8b3b5/creator-node/src/routes/tracks.js for previous behavior
SidSethi
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello Card Link
Description
Services
Does it touch a critical flow like Discovery indexing, Creator Node track upload, Creator Node gateway, or Creator Node file system?
Delete an option.
How Has This Been Tested?
It hasn't, yet
Please list the unit test(s) you added to verify your changes.
None