Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse bool correctly #916

Merged
merged 1 commit into from Oct 9, 2020
Merged

Parse bool correctly #916

merged 1 commit into from Oct 9, 2020

Conversation

jowlee
Copy link
Contributor

@jowlee jowlee commented Oct 9, 2020

Trello Card Link

na

Description

Fix Call to tracks endpt with show_unlisted=false don't work correctly, 400
Link to docs https://flask-restx.readthedocs.io/en/latest/parsing.html#advanced-types-handling
Link to input bool docs https://flask-restx.readthedocs.io/en/latest/api.html#flask_restx.inputs.boolean

Services

Discovery Provider

Does it touch a critical flow like Discovery indexing, Creator Node track upload, Creator Node gateway, or Creator Node file system?

Delete an option.

  • ✅ Nope

How Has This Been Tested?

ran locally

@jowlee jowlee requested a review from piazzatron October 9, 2020 20:05
Copy link
Contributor

@piazzatron piazzatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find. I'm surprised all the int ones work given that it requires this input package

@jowlee jowlee merged commit 9870f49 into master Oct 9, 2020
@jowlee jowlee deleted the jowlee-bool-param branch October 9, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants