Add play check to discprov

[raymondjacobson]

Trello Card Link

https://trello.com/c/wM570Sl6/1607-add-play-check-to-discprov

Description

Adds a /play_check to discprov that returns the latest created Play in the db. Endpoint takes an optional max_drift query param that is used to check whether to return a 500.

Services

• Discovery Provider

Does it touch a critical flow like Discovery indexing, Creator Node track upload, Creator Node gateway, or Creator Node file system?

Delete an option.

• ✅ Nope

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Include log analysis if applicable.

1. Local discprov, tested with and without query param

Please list the unit test(s) you added to verify your changes.

1. get_latest_play_test.py

[dmanjunath]

The code looks good overall, had one question. The thing about this is I'm not sure if relying on a play actually happening is the best proxy for this check. Ideally we could just write something into redis like last_indexed_play after the lock has been acquired and we index, and then check that time against current time. We could still reuse drift as the max interval in when a play index should have happened

[dmanjunath]

is there a default value? if we just hit play_check this would probably fail cause max_drift is None?

[raymondjacobson]

The code looks good overall, had one question. The thing about this is I'm not sure if relying on a play actually happening is the best proxy for this check. Ideally we could just write something into redis like last_indexed_play after the lock has been acquired and we index, and then check that time against current time. We could still reuse drift as the max interval in when a play index should have happened

I feel like this is the user facing manifestation that "something has gone wrong" and it's how we discovered the last issue we had (the last db play was behind by 4hrs).

I guess I understand your point about wanted to test the indexing vs whether a play actually happened, but I could see indexing happening but being broken (or identity being broken) and then us passing the check "did we index" but still falling behind.

[dmanjunath]

That's a fair point. As long as we have a sane time set for the drift i think this should be okay. Like how do you feel about 5 mins?

[raymondjacobson]

I was gonna say an hour lol :)

[dmanjunath]

oh that's perfect! approving