Add shared tracks cache for get_tracks #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any harm you can think of from removing the cache layer that I did here? |
raymondjacobson
approved these changes
Oct 13, 2020
| @@ -91,8 +100,7 @@ def get_unpopulated_track(): | |||
|
|
|||
| return (tracks, track_ids) | |||
|
|
|||
| key = make_cache_key(args) | |||
| (tracks, track_ids) = use_redis_cache(key, UNPOPULATED_TRACK_CACHE_DURATION_SEC, get_unpopulated_track) | |||
| (tracks, track_ids) = get_tracks_and_ids() | |||
There was a problem hiding this comment.
should we be adding to cache in the event that we do get stuff from the db here?
There was a problem hiding this comment.
discussed on slack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds shared caching for
get_tracks, so we get at leat some level of caching for bulk fetches.This gets rid of the existing get_unpopulated_tracks caching function.
Services
Does it touch a critical flow like Discovery indexing, Creator Node track upload, Creator Node gateway, or Creator Node file system?
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Include log analysis if applicable.
Tested locally against prod, made sure we returned expected results + hit cache when expected.