Full signatures & remove signatures from health_check #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondjacobson
changed the title
dmanjunath
suggested changes
Oct 14, 2020
| @@ -30,23 +30,16 @@ def default(self, o): # pylint: disable=E0202 | |||
| def error_response(error, error_code=500): | |||
| return jsonify({'success': False, 'error': error}), error_code | |||
|
|
|||
| # Create a response dict with just data, signature, and timestamp | |||
| # This response will contain a duplicate of response_entity | |||
| def success_response_backwards_compat(response_entity=None, status=200): | |||
There was a problem hiding this comment.
unfortunately i don't think we can remove this quite yet. i think while libs are upgraded, there are places that are still using the old format https://github.com/AudiusProject/audius-protocol/blob/master/identity-service/src/routes/healthCheck.js#L216
There was a problem hiding this comment.
fair enough. won't remove yet :)
dmanjunath
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello Card Link
https://trello.com/c/inyb5DjL/1609-fix-full-models-to-include-signatures-remove-sigs-from-health-check
Description
Signatures are actually pretty expensive.
We do need to keep them for most endpoints, but we don't need them for health check
Moves success_response_backwards_compat from discprov (All of our services should have upgraded to libs past this / they absolutely will need to for new contracts)
Adds
walletto full response for user objectAdds signatures to v1/full
Services
Does it touch a critical flow like Discovery indexing, Creator Node track upload, Creator Node gateway, or Creator Node file system?
Delete an option.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Include log analysis if applicable.