New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eventlet support and gunicorn config vals #951
Conversation
|
||
# Use specified number of workers if present | ||
if [[ -z "${audius_gunicorn_workers}" ]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there an associated config update that is missing?
[discprov] |
i also think these should be audius_discprov_gunicorn_workers if we follow the format for other configs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh because these are environment configs and not used by the service this doesn't really matter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah -- the .ini is for python, this is before python's even running
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
config is all updated on the k8s side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a world in which we want this locally too, but we never run gunicorn locally as it stands, so it doesn't make a diff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Trello Card Link
https://trello.com/c/FJa1ydwW/1619-template-gunicorn-config
Description
Templates the gunicorn config for discovery provider with env vars.
Corresponding k8s change: https://github.com/AudiusProject/audius-k8s/pull/135
Services
Does it touch a critical flow like Discovery indexing, Creator Node track upload, Creator Node gateway, or Creator Node file system?
Delete an option.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Include log analysis if applicable.
master
and audius-k8s at the branch)With new audius-k8s
with old audius-k8s