Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh discprov cnodes list from new identity route, to ensure newly added cnodes are integrated on registration #963

Merged
merged 4 commits into from Oct 22, 2020

Conversation

SidSethi
Copy link
Contributor

@SidSethi SidSethi commented Oct 22, 2020

Trello Card Link

Description

Anytime a new creator node is registered and content is uploaded for the first time, discprovs have not peered to the new CN and will fail to fetch the new user metadata from it. This is a temporary fix for this problem: identity already has an eth-contracts connection, so we added a new route to fetch the list of registered cnodes from chain. discprov indexing task now updates its cnode_endpoints list from this route and peers with the new cnodes' ipfs node.

Services

  • Discovery Provider
  • Creator Node
  • Identity Service
  • Libs
  • Contracts
  • Service Commands
  • Mad Dog

Does it touch a critical flow like Discovery indexing, Creator Node track upload, Creator Node gateway, or Creator Node file system?

Delete an option.

  • 馃毃 Yes, this touches discprov indexing (barely)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Include log analysis if applicable.

  1. Deployed discprov and identity to staging with this code, confirmed it works. Registered new CN (http://54.67.117.176:31818/) on stage to ensure new IP. signed up, selected new CN as primary, and uploaded content. confirmed indexing flow queries identity and fetches new endpoints from identity
{"levelno": 20, "level": "INFO", "msg": "Redis Cache - miss registered_cnodes_from_identity", "timestamp": "2020-10-22 02:30:39,520"}
{"levelno": 20, "level": "INFO", "msg": "Fetched registered creator nodes from chain via https://identityservice.staging.audius.co/registered_creator_nodes", "timestamp": "2020-10-22 02:30:40,295"}

Confirmed Upload went through successfully on CN

Please list the unit test(s) you added to verify your changes.

Copy link
Contributor

@dmanjunath dmanjunath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants