67 unit tests #152
Merged
67 unit tests #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st folder, found issue with tools resetting augur, commented out account.js unit tests until bug is fixed so unit tests will pass for now
…ccount to avoid errors with tests. I dont think these reset statements appear to be required
…buyandsellshares unit tests
…g, filters, contracts, branches, batch, and modified accounts to no longer run tests that require connecting to a server since that is not a unit test. will need to rework tests so that they only test the code in augur.js, orignial implementations will be left in other test folders for integration testing
…tion implemented by Jack
…he tests, still need a bit of work to get the same format
…rectly or im misunderstanding something. Added transact unit tests.
…ion to correctly pass onFailed to this.transact
… the correct augur-contract address
…h not catching an error gracefully.
…an error without failing gracefully when adding a transaction to batch without a contract defined.
…h an error key but never return it to the callback, added more unit tests to logs
…nit tests for logs
…ation, added more unit tests to logs
…ompleteSetsLogs when options was passed as undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests so far... still have some to complete.