Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors when using with Vue 3 #218

Merged
merged 11 commits into from
Nov 8, 2020
Merged

Fix errors when using with Vue 3 #218

merged 11 commits into from
Nov 8, 2020

Conversation

aklinker1
Copy link
Contributor

Summary

This closes #217

  • Updated plugin structure to use install method to fix TS error mentioned in the issue
  • Added composition helper function, useReCaptcha
  • Upgraded to vue@^3.0.0-rc.5

Resources

Other Comments

  • First time writing a plugin, so I might have over-restructured the main file
  • README.md might have some lint errors in new example code, your code style is different than mine but I tried to match it, so let me know if I missed anything
  • Couldn't get the demo application working, webpack was complaining about not being able to find the "vue" module, but I did do manual testing on my personal project and both the new useReCaptcha and old usage were working.

@aklinker1 aklinker1 mentioned this pull request Sep 14, 2020
@WipeAir
Copy link
Contributor

WipeAir commented Oct 1, 2020

Hey, sorry for the delay! I haven't had any time yet to look into this topic.
I'll check your PR in the coming days and fix the things you've mentioned.

@aklinker1
Copy link
Contributor Author

No worries, I understand completely! Most major plugins don't work with vue3 yet either.

@aklinker1
Copy link
Contributor Author

I'll get the conflicts sorted out sometime soon.

@WipeAir WipeAir merged commit 0f0af6b into AurityLab:master Nov 8, 2020
@WipeAir
Copy link
Contributor

WipeAir commented Nov 8, 2020

Thanks for the PR! Just merged it into the master (and fixed some minor problems).
The demo application is working fine again and the code style matches the original ESLint configuration. :)

@aklinker1 aklinker1 deleted the vue-3-support branch November 11, 2020 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue 3 Support
2 participants