Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix div-by-zero errors on files which don't have any changed content #7

Merged
merged 1 commit into from Dec 7, 2020

Conversation

Obi-Dann
Copy link
Collaborator

@Obi-Dann Obi-Dann commented Dec 7, 2020

Copy of Squirrel#1361

There are cases where the length in write operations becomes zero, at which point this code will throw an exception and fail to create bsdiff deltas.

As this is critical to our production workflow, it has been temporarily published as ppy.Squirrel.windows (along with several other PRs that are not merged into official releases yet).

Test files which cause the issue to reproduce (large): https://www.dropbox.com/sh/p13oiqir02xzny1/AABUHNZeP2u2T-AjViFYCG6na?dl=0

@Obi-Dann Obi-Dann merged commit f917372 into v1.x Dec 7, 2020
@Obi-Dann Obi-Dann deleted the revert-6-revert-5-fix-div-by-zero branch December 7, 2020 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant