Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix div-by-zero errors on files which don't have any changed content #1361

Closed
wants to merge 1 commit into from

Conversation

peppy
Copy link

@peppy peppy commented Aug 2, 2018

There are cases where the length in write operations becomes zero, at which point this code will throw an exception and fail to create bsdiff deltas.

As this is critical to our production workflow, it has been temporarily published as ppy.Squirrel.windows (along with several other PRs that are not merged into official releases yet).

Test files which cause the issue to reproduce (large): https://www.dropbox.com/sh/p13oiqir02xzny1/AABUHNZeP2u2T-AjViFYCG6na?dl=0

@augustoproiete
Copy link

@peppy The test files are no longer available on your Dropbox. Would you be able to upload them somewhere else?

image

@peppy
Copy link
Author

peppy commented Jan 25, 2019

Sorry about that! I've restored the files, so the link should work again.

@adabru
Copy link

adabru commented Apr 2, 2021

@peppy, does #1421 achieve the same thing?

@peppy
Copy link
Author

peppy commented Apr 2, 2021

I have no idea, but the test files are still available if you'd like to try.

We have long since given up hope and maintain our own fork.

@adabru
Copy link

adabru commented Apr 15, 2021

Thanks for open sourcing and distributing your fork on nuget. I switched to your fork.

@MichaelBelousov
Copy link

looks related to #1784

@caesay
Copy link

caesay commented Apr 27, 2022

This is the same problem that was fixed in #1421 and has already been merged to master. I don't know if this fix has been released on nuget, but this PR can be closed. It is also fixed in my fork which has superseded the ppy.Squirrel.windows package.

@robmen robmen closed this Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants