Fixes loadout naming #11759
Merged
Fixes loadout naming #11759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!bugfix |
BotBOREALIS
added
the
Bugfix
|
!review |
Alberyk
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fully fixes handkerchief naming and should make future loadout additions with name changing elements more proof as long as the relevant items are modified to fit.
Quick instructions for future additions to loadout: if an item at any point change name, they should get a var called
base_nameand this var should be used in those places. Under initialise this var should be given the name of the item. The loadout will then change this var if an item is renamed with it.Credits to Geeves for discussing ideas with me.