Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double Round Rolls #12547

Closed
wants to merge 10 commits into from
Closed

Conversation

Geevies
Copy link
Contributor

@Geevies Geevies commented Sep 23, 2021

  • Players who have played a role the previous round will now be the last in line for candidates chosen for the same role in the current round. You only count as having played a role if you join it before one hour has elapsed.

Feedback thread: https://forums.aurorastation.org/topic/16572-feedback-double-round-rolls/

@Geevies
Copy link
Contributor Author

Geevies commented Sep 23, 2021

!review

@FayeLovesU
Copy link
Contributor

Long overdue IMO. This is a great and I'd almost wager necessary change for people who play few-slot roles that are highly contested like Investigator.

@Jaraci
Copy link
Contributor

Jaraci commented Sep 23, 2021

Does this apply to latejoiners or only people who take the role at roundstart? Just curious.

@Geevies
Copy link
Contributor Author

Geevies commented Sep 23, 2021

Does this apply to latejoiners or only people who take the role at roundstart? Just curious.

just pushed an update. it counts for roundstart and latejoiners, but latejoining after one hour has passed will not cause it

@NonQueueingMatt
Copy link
Contributor

I personally disagree with latejoiners counting. I don't think it should apply to people who queued for a slot and lost the roll and joined later. At the same time, I don't think it should apply to people who join into a slot that wasn't contested.

@AnselmKonrad
Copy link

AnselmKonrad commented Sep 23, 2021

I dont agree with making this applicable to late joining. I can understand perhaps somehow reducing it but, the choosing of people getting a role is supposed to be random already. Mainly though, how does this stop someone from exactly stopping someone from playing the role again for the next round? does this just entirely stop someone from selecting that role at all? does it just put them at the end of a queue? do they get a decreased chance instead? I can see this only killing the server pop for people who main a single character which is, frankly, a lot of people.

@Geevies
Copy link
Contributor Author

Geevies commented Sep 23, 2021

I personally disagree with latejoiners counting. I don't think it should apply to people who queued for a slot and lost the roll and joined later. At the same time, I don't think it should apply to people who join into a slot that wasn't contested.

why?

I dont agree with making this applicable to late joining. I can understand perhaps somehow reducing it but, the choosing of people getting a role is supposed to be random already. Mainly though, how does this stop someone from exactly stopping someone from playing the role again for the next round? does this just entirely stop someone from selecting that role at all? does it just put them at the end of a queue? do they get a decreased chance instead? I can see this only killing the server pop for people who main a single character which is, frankly, a lot of people.

last in queue

@AnselmKonrad
Copy link

Last in queue

So this stops them from joining next round if anyone contests the role at all?

@Geevies
Copy link
Contributor Author

Geevies commented Sep 23, 2021

Last in queue

So this stops them from joining next round if anyone contests the role at all?

yeah. but it checks high, medium, and low too

@@ -113,6 +113,8 @@
position_limit = job.get_spawn_positions()
if((job.current_positions < position_limit) || position_limit == -1)
Debug("Player: [player] is now Rank: [rank], JCP:[job.current_positions], JPL:[position_limit]")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The time played should be a configuration value.
It should also be possible to disable this system via a special configuration value. i.e. -1

Copy link
Member

@Arrow768 Arrow768 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like I never actually submitted that review, so here we go

The default should maintain the existing behavior.

code/controllers/configuration.dm Outdated Show resolved Hide resolved
config/example/config.txt Outdated Show resolved Hide resolved
Co-authored-by: Werner <1331699+Arrow768@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented May 6, 2022

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@NonQueueingMatt
Copy link
Contributor

Conflicts. Will get re-discussed if anyone re-opens this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants