New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Double Round Rolls #12547
Double Round Rolls #12547
Conversation
!review |
Long overdue IMO. This is a great and I'd almost wager necessary change for people who play few-slot roles that are highly contested like Investigator. |
Does this apply to latejoiners or only people who take the role at roundstart? Just curious. |
just pushed an update. it counts for roundstart and latejoiners, but latejoining after one hour has passed will not cause it |
I personally disagree with latejoiners counting. I don't think it should apply to people who queued for a slot and lost the roll and joined later. At the same time, I don't think it should apply to people who join into a slot that wasn't contested. |
I dont agree with making this applicable to late joining. I can understand perhaps somehow reducing it but, the choosing of people getting a role is supposed to be random already. Mainly though, how does this stop someone from exactly stopping someone from playing the role again for the next round? does this just entirely stop someone from selecting that role at all? does it just put them at the end of a queue? do they get a decreased chance instead? I can see this only killing the server pop for people who main a single character which is, frankly, a lot of people. |
why?
last in queue |
So this stops them from joining next round if anyone contests the role at all? |
yeah. but it checks high, medium, and low too |
@@ -113,6 +113,8 @@ | |||
position_limit = job.get_spawn_positions() | |||
if((job.current_positions < position_limit) || position_limit == -1) | |||
Debug("Player: [player] is now Rank: [rank], JCP:[job.current_positions], JPL:[position_limit]") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The time played should be a configuration value.
It should also be possible to disable this system via a special configuration value. i.e. -1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like I never actually submitted that review, so here we go
The default should maintain the existing behavior.
Co-authored-by: Werner <1331699+Arrow768@users.noreply.github.com>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts. Will get re-discussed if anyone re-opens this. |
Feedback thread: https://forums.aurorastation.org/topic/16572-feedback-double-round-rolls/