Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an origin and culture system to govern possible faction items, citizenships, accents, religions. #13400

Merged
merged 54 commits into from Apr 24, 2022

Conversation

NonQueueingMatt
Copy link
Contributor

@NonQueueingMatt NonQueueingMatt commented Mar 18, 2022

As per title, this will vanquish or at the very least help with a lot of problems (such as people missing naming/skintone requirements for certain human factions or people grabbing faction items not meant for their factions).

The intent is for accents, citizenships and religions to also be limited to what that specific origin allows you to pick as well.

To-do:

  • Head staff approval.
  • Get the loreteam to draft up a list of origins + cultures for every faction of every species, plus possible citizenships/accents/religions for that origin.
  • Add possible species overrides for cultures and origin.
  • Possibly change accents/citizenships/religions to use decls.
  • Figure out how to save the Origins settings in the database, since I don't think we can save types. Since they must be strings, I guess I have to make a list on some subsystem.
  • Sanitization fixes.
  • Add culture/origin selection to antags (specifically, the changer machine).
  • Add culture/origin to human default init, since right now it's only a pref thing while it's a proof of concept.
  • SQL.

@NonQueueingMatt
Copy link
Contributor Author

!wip

@BotBOREALIS BotBOREALIS added the WIP The PR is a work in progress and should not be reviewed yet. label Mar 18, 2022
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Matt Atlas added 2 commits April 17, 2022 15:41
# Conflicts:
#	code/modules/client/preference_setup/loadout/loadout_general.dm
@BotBOREALIS BotBOREALIS added 🚫 Do Not Merge VueUI For PRs or issues related to VueUI. labels Apr 17, 2022
code/controllers/subsystems/job.dm Outdated Show resolved Hide resolved
code/controllers/subsystems/job.dm Outdated Show resolved Hide resolved
code/controllers/subsystems/job.dm Outdated Show resolved Hide resolved
code/controllers/subsystems/job.dm Outdated Show resolved Hide resolved
code/modules/background/origins/origins/diona/biesel.dm Outdated Show resolved Hide resolved
code/modules/background/origins/origins/vaurca/zora.dm Outdated Show resolved Hide resolved
code/modules/client/preference_setup/general/03_body.dm Outdated Show resolved Hide resolved
code/modules/client/preference_setup/general/03_body.dm Outdated Show resolved Hide resolved
code/modules/client/preference_setup/origin/origin.dm Outdated Show resolved Hide resolved
code/modules/client/preference_setup/origin/origin.dm Outdated Show resolved Hide resolved
code/modules/client/preference_setup/origin/origin.dm Outdated Show resolved Hide resolved
code/modules/mob/living/carbon/human/human.dm Outdated Show resolved Hide resolved
code/unit_tests/origins_tests.dm Show resolved Hide resolved
code/unit_tests/origins_tests.dm Show resolved Hide resolved
code/unit_tests/origins_tests.dm Outdated Show resolved Hide resolved
Matt Atlas added 3 commits April 22, 2022 12:19
# Conflicts:
#	code/modules/mob/living/carbon/human/species/station/skrell/skrell.dm
@Arrow768 Arrow768 merged commit b7b9db1 into Aurorastation:master Apr 24, 2022
JohnWildkins pushed a commit to JohnWildkins/Aurora.3 that referenced this pull request May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Merge VueUI For PRs or issues related to VueUI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants