New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds an origin and culture system to govern possible faction items, citizenships, accents, religions. #13400
Merged
Arrow768
merged 54 commits into
Aurorastation:master
from
NonQueueingMatt:kyojuro_become_a_demon
Apr 24, 2022
Merged
Adds an origin and culture system to govern possible faction items, citizenships, accents, religions. #13400
Arrow768
merged 54 commits into
Aurorastation:master
from
NonQueueingMatt:kyojuro_become_a_demon
Apr 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
!wip |
BotBOREALIS
added
the
WIP
The PR is a work in progress and should not be reviewed yet.
label
Mar 18, 2022
NonQueueingMatt
force-pushed
the
kyojuro_become_a_demon
branch
from
April 15, 2022 16:08
938111e
to
08152eb
Compare
NonQueueingMatt
force-pushed
the
kyojuro_become_a_demon
branch
from
April 17, 2022 12:15
cf922ec
to
14ada10
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
# Conflicts: # code/modules/client/preference_setup/loadout/loadout_general.dm
NonQueueingMatt
force-pushed
the
kyojuro_become_a_demon
branch
from
April 20, 2022 19:53
429ef6e
to
2b26787
Compare
mikomyazaki
requested changes
Apr 20, 2022
code/modules/background/origins/origins/unathi/traditionalist.dm
Outdated
Show resolved
Hide resolved
mikomyazaki
requested changes
Apr 20, 2022
NonQueueingMatt
force-pushed
the
kyojuro_become_a_demon
branch
from
April 21, 2022 13:19
027e292
to
b21c464
Compare
mikomyazaki
approved these changes
Apr 21, 2022
# Conflicts: # code/modules/mob/living/carbon/human/species/station/skrell/skrell.dm
mikomyazaki
approved these changes
Apr 23, 2022
JohnWildkins
approved these changes
Apr 23, 2022
JohnWildkins
pushed a commit
to JohnWildkins/Aurora.3
that referenced
this pull request
May 24, 2022
…itizenships, accents, religions. (Aurorastation#13400)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title, this will vanquish or at the very least help with a lot of problems (such as people missing naming/skintone requirements for certain human factions or people grabbing faction items not meant for their factions).
The intent is for accents, citizenships and religions to also be limited to what that specific origin allows you to pick as well.
To-do: