Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reworks Portable Generators #13663

Merged
merged 9 commits into from May 6, 2022
Merged

Reworks Portable Generators #13663

merged 9 commits into from May 6, 2022

Conversation

SleepyGemmy
Copy link
Contributor

@SleepyGemmy SleepyGemmy commented Apr 24, 2022 •
edited

this PR reworks the portable generators and more accurately describes their function, both in name and description. it also adds graphite as the basic generator's fuel source. you can make graphite from compressing coal in the mining refinery.

changes:

  • adds graphite sheets and uses this as the most basic type of fuel.
  • adds lighting to the generators when they are active.

images:
image
fig. 1: new graphite portable generator sprite.

image
fig. 2: new lighting added to generators when active.

@BotBOREALIS BotBOREALIS added Changelog Required 🗺️ Mapping - Aurora The PR touches the Aurora map files. labels Apr 24, 2022
@SleepyGemmy
Copy link
Contributor Author

!review

@BotBOREALIS BotBOREALIS added the VueUI For PRs or issues related to VueUI. label Apr 24, 2022
@SleepyGemmy SleepyGemmy marked this pull request as draft April 26, 2022 13:35
@SleepyGemmy SleepyGemmy marked this pull request as ready for review April 27, 2022 08:43
@SleepyGemmy SleepyGemmy changed the title Refluffs Portable Generators Reworks Portable Generators Apr 29, 2022
@BotBOREALIS BotBOREALIS added the Sprites Adds new or changes existing sprites. label Apr 29, 2022
@github-actions
Copy link

github-actions bot commented May 1, 2022

This pull request has conflicts, please resolve those before we can evaluate the pull request.

NonQueueingMatt
NonQueueingMatt approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@NonQueueingMatt NonQueueingMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright. I think the buffs are nice.

@NonQueueingMatt NonQueueingMatt merged commit 7387080 into Aurorastation:master May 6, 2022
@SleepyGemmy SleepyGemmy deleted the portable_generator_refluff branch May 6, 2022 12:21
JohnWildkins pushed a commit to JohnWildkins/Aurora.3 that referenced this pull request May 24, 2022
@SleepyGemmy @JohnWildkins
Reworks Portable Generators (Aurorastation#13663)
9fcc986
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alsoandanswer alsoandanswer alsoandanswer left review comments

@JohnWildkins JohnWildkins JohnWildkins approved these changes

@NonQueueingMatt NonQueueingMatt NonQueueingMatt approved these changes

@Arrow768 Arrow768 Awaiting requested review from Arrow768 Arrow768 is a code owner

Assignees
No one assigned
Labels
Awaiting Merge 🗺️ Mapping - Aurora The PR touches the Aurora map files. Sprites Adds new or changes existing sprites. VueUI For PRs or issues related to VueUI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SleepyGemmy @JohnWildkins @NonQueueingMatt @alsoandanswer @BotBOREALIS