Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Independent Assistants #18371

Merged
merged 1 commit into from Feb 11, 2024
Merged

Conversation

Ben10083
Copy link
Contributor

@Ben10083 Ben10083 commented Feb 8, 2024

Assistants are now possible as independents. Taken from this forum post

@Arrow768 Arrow768 added 🚫 Do Not Merge ⛔ Maintainer Discussion The PR will be discussed by the maintainers. labels Feb 11, 2024
@NonQueueingMatt NonQueueingMatt added this pull request to the merge queue Feb 11, 2024
Merged via the queue into Aurorastation:master with commit d9a3901 Feb 11, 2024
20 checks passed
Arrow768 added a commit that referenced this pull request Feb 11, 2024
@Ben10083
Copy link
Contributor Author

This says so much about society

@Arrow768
Copy link
Member

Arrow768 commented Feb 11, 2024

The "maintainer discussion" and "do not merge" labels were not considered when this PR has been queued for merge.

That maintainer discussion has since happened, and we decided not to keep it for the following reasons:

Regulation issues
As currently defined in our regs assistants are subordinate to any crew member. (see the chain of command on the wiki)
Accordingly, "independent" assistants would also be beholden to that chain of command, therefore rendering them rather useless as "consular assistants".

This could potentially be fixed by updating the regulations for "independent" assistants.
However that leads us to the second issue.

Assistant Capacity
If we added a exception to our regulations that independent assistants are not beholden to the chain of commands this leaves us with the issue of "assistant capacity".
As implemented in this PR, there are no mechanical restrictions that would prevent for example a chaplain from bringing their personal choir. Or (any other position) from having a multitude of assistants.

And finally, there is also the issue of

Leading Job Presence
With the current implementation, there are no mechanical restrictions that prevent a independent assistant from spawning if the leading role (i.e. consular) isnt present, therefore creating a unwhitelisted entity that's almost entirely outside the chain of command (if the above mentioned regulation changes are applied).

As such the PR has been reverted and any future implementation of "consular assistants" would need to have the following features:

  • Distinct Role/Job
  • Limited to 1 Assistant per consular
  • Jobslot manually enabled by the consular.
  • The same species/origin/... restrictions applied as to the consular (with the exception of vaurca where the assistant can be a worker, but can not be a breeder)

@Ben10083 Ben10083 deleted the Indep_Assistant branch February 15, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Merge 🚫 Do Not Merge ⛔ Maintainer Discussion The PR will be discussed by the maintainers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants