Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Suggestions Bonanza #4234

Closed
wants to merge 1 commit into from
Closed

[WIP] Suggestions Bonanza #4234

wants to merge 1 commit into from

Conversation

LordFowl
Copy link
Contributor

@LordFowl LordFowl commented Feb 1, 2018

@LordFowl LordFowl added the WIP The PR is a work in progress and should not be reviewed yet. label Feb 1, 2018
@skull132
Copy link
Contributor

skull132 commented Feb 1, 2018

> Master

@LordFowl LordFowl changed the base branch from master to development February 1, 2018 21:48
@LordFowl
Copy link
Contributor Author

LordFowl commented Feb 1, 2018

What are you talking about? Senile old developer.

@Arrow768
Copy link
Member

Arrow768 commented Feb 1, 2018

I think with the current implementation of the department function, you can just add people to new departments, but you would not remove them from the old department when you change the department ?

@LordFowl
Copy link
Contributor Author

LordFowl commented Feb 2, 2018

Department is based on string comparison to assignment. A person can only have one assignment, custom or otherwise, unless the records system has glitched in which case there would be two entries anyways.

@LordFowl LordFowl added the Stale Has not been updated by its author for a long time. label Mar 14, 2018
@LordFowl LordFowl closed this Jun 17, 2018
@LordFowl LordFowl reopened this Jun 17, 2018
@LordFowl LordFowl closed this Oct 30, 2018
@LordFowl LordFowl reopened this Oct 30, 2018
@Arrow768 Arrow768 closed this Dec 20, 2018
@LordFowl LordFowl deleted the Solid_Snake branch January 26, 2019 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alberyk Alberyk Awaiting requested review from Alberyk

@Arrow768 Arrow768 Awaiting requested review from Arrow768

Assignees
No one assigned
Labels
Stale Has not been updated by its author for a long time. WIP The PR is a work in progress and should not be reviewed yet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LordFowl @skull132 @Arrow768