Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Virologist, Create Biochemist (Bring The Sanitizer) #4549

Conversation

JackBewt
Copy link

@JackBewt JackBewt commented Apr 7, 2018

An actual PR this time.
The Virologist role is being deleted and merged into the Chemist role with the new name of Biochemist. The Pharmacist alt-title is kept the same.
More info here:
https://forums.aurorastation.org/viewtopic.php?f=18&t=10266

@skull132 skull132 added the WIP The PR is a work in progress and should not be reviewed yet. label Apr 7, 2018
/datum/job/chemist
title = "Chemist"
flag = CHEMIST
/datum/job/Biochemist
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Types should be lowercase.

@@ -77,7 +76,7 @@ var/list/medical_positions = list(
"Chief Medical Officer",
"Medical Doctor",
"Psychiatrist",
"Chemist",
"BioChemist",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure chemist should be lowercase here.

@Bygonehero
Copy link

Against this completely. The two disciplines are completely different and serve very different purposes, neither of which are really handled by the fake title of biochemist. The problem cited for its creation is an extant one that rarely if ever is a problem.

@LordFowl LordFowl added the Stale Has not been updated by its author for a long time. label Jul 15, 2018
@skull132
Copy link
Contributor

Stale, closing.

@skull132 skull132 closed this Jul 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Has not been updated by its author for a long time. WIP The PR is a work in progress and should not be reviewed yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants