Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airlock Maintenance Hatches #480

Merged
merged 3 commits into from
Jul 11, 2016
Merged

Conversation

NanakoAC
Copy link
Contributor

@NanakoAC NanakoAC commented Jun 27, 2016

  • rscadd: "Added maintenance hatches to most airlocks and hazard shutters, for drones to pass through without opening the door. Hatches do not allow gases through or spread breaches"

@NanakoAC NanakoAC changed the title - rscadd: "Added maintenance hatches to most airlocks and hazard shutters, for drones to pass through without opening the door. Hatches do not allow gases through or spread breaches" Airlock Maintenance Hatches Jun 27, 2016
@Bedshaped
Copy link
Contributor

Bedshaped commented Jun 27, 2016

I was thinking, would it be worthwhile that they have to be in "hide" mode so they don't accidentally walk into an area that might kill them?

@NanakoAC
Copy link
Contributor Author

NanakoAC commented Jun 27, 2016

drones are pretty sturdy, they can survive serious heat. Even walking into a raging phoron fire only hurts them much if they hang around for a while

Source: I once set science on fire by accident, and then ran around in the fire for several minutes trying to breach it out

Also, there's no hatches on external airlocks, so they won't accidentally walk out into space

@Arrow768
Copy link
Member

The changes to the atmos alert and station alert computer are not included in the changelog

@NanakoAC
Copy link
Contributor Author

NanakoAC commented Jul 2, 2016

the atmos/alert computer aren't changes, they're just merging in a hotfix that skull wrote because it was unuseable without it, there was a bug at that time. i figured development was updated now, maybe i need to rebase it

If you look at those files in development, i believe their state is already identical to what's in this PR

@skull132
Copy link
Contributor

skull132 commented Jul 2, 2016

Rebasing should fix it. However, I can also tell you that in the present form, it's fine.

I accepted and squashed another pull with a similar issue, and the files were unmodified. Most likely github having trouble with something?

@NanakoAC
Copy link
Contributor Author

NanakoAC commented Jul 5, 2016

I did the new branch > Merge > Overwrite original remote thing, to fix it

/mob/living/silicon/Move(newloc, direct)
..(newloc,direct)
if (underdoor)
if (!(layer == UNDERDOOR))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're forcing underdoor = 0 regardless of circumstance on line line 363, then why do it conditionally just beforehand? Mistake, or oversight?

@skull132 skull132 added Changes Required The PR requires changes before it can be approved and/or merged. Review Required and removed Review Required labels Jul 5, 2016
@NanakoAC NanakoAC added Feedback Required The PR requires a feedback topic and feedback on the forum. and removed Review Required labels Jul 8, 2016
@skull132 skull132 added Awaiting Merge and removed Changes Required The PR requires changes before it can be approved and/or merged. Feedback Required The PR requires a feedback topic and feedback on the forum. labels Jul 11, 2016
@skull132 skull132 merged commit 0c749c5 into Aurorastation:development Jul 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants