-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Airlock Maintenance Hatches #480
Conversation
NanakoAC
commented
Jun 27, 2016
•
edited
edited
- rscadd: "Added maintenance hatches to most airlocks and hazard shutters, for drones to pass through without opening the door. Hatches do not allow gases through or spread breaches"
I was thinking, would it be worthwhile that they have to be in "hide" mode so they don't accidentally walk into an area that might kill them? |
drones are pretty sturdy, they can survive serious heat. Even walking into a raging phoron fire only hurts them much if they hang around for a while Source: I once set science on fire by accident, and then ran around in the fire for several minutes trying to breach it out Also, there's no hatches on external airlocks, so they won't accidentally walk out into space |
The changes to the atmos alert and station alert computer are not included in the changelog |
the atmos/alert computer aren't changes, they're just merging in a hotfix that skull wrote because it was unuseable without it, there was a bug at that time. i figured development was updated now, maybe i need to rebase it If you look at those files in development, i believe their state is already identical to what's in this PR |
Rebasing should fix it. However, I can also tell you that in the present form, it's fine. I accepted and squashed another pull with a similar issue, and the files were unmodified. Most likely github having trouble with something? |
I did the new branch > Merge > Overwrite original remote thing, to fix it |
/mob/living/silicon/Move(newloc, direct) | ||
..(newloc,direct) | ||
if (underdoor) | ||
if (!(layer == UNDERDOOR)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're forcing underdoor = 0
regardless of circumstance on line line 363, then why do it conditionally just beforehand? Mistake, or oversight?