Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Journalism, vol 2. Freedom Unbecoming. #4999

Merged
merged 6 commits into from Jul 22, 2018

Conversation

skull132
Copy link
Contributor

Implements this: https://forums.aurorastation.org/viewtopic.php?f=21&t=11375&start=10#p101753

Basically: journalists get immunity from D-notices, corporate reports get extended access. Also added a mechanism to add alt title based access more easily.

And I'm still torn whether or not to enforce the D-notice restriction mechanically or not. Doing it mechanically might be a bit ugly.

@skull132 skull132 added Review Required Feedback Required The PR requires a feedback topic and feedback on the forum. labels Jul 15, 2018
@skull132 skull132 added this to the July Update milestone Jul 15, 2018
@skull132 skull132 requested a review from Arrow768 as a code owner July 15, 2018 20:35
return src.access.Copy()
. = access.Copy()

if (LAZYLEN(title_accesses) && title_accesses[selected_title])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alternately: if (LAZYACCESS(title_accesses, selected_title))

@XanderDox
Copy link

As the originator of this suggestion - I myself reached out to some Captain players about what they would do if there was a regulation/directive saying that cannot D-Notice Freelance Journalists...

The results was pretty much as I expected, and most said they would outright ignore the directive and just cite their ultimate authority to break regulations when required and D-Notice them anyways. This is why I think, quite strongly, that the inability to D-Notice should be mechanical.

Alternatively, disallow D-Noticing for Freelancers during Green and Blue, but enable it on Red/Delta. This might be harder to code, but would be a better middle ground then directly putting it into the hands of players.

@skull132
Copy link
Contributor Author

The results was pretty much as I expected, and most said they would outright ignore the directive and just cite their ultimate authority to break regulations when required and D-Notice them anyways. This is why I think, quite strongly, that the inability to D-Notice should be mechanical.

Alternatively. Let CCIAA mop it up.

The code for the D-Notice stopper is hacky at best, with there not being any good way to recognize alternate titles without doing what I've done. Ultimately it seems kinda weird that the Captain doesn't have that authority.

At present, I'm probably going to remove the restriction and see how it goes. If need be, it's easy enough to shove back in down the road.

…fyoufindsomeoneabusingthisaaaaaaaaaaaaaaaaaaaaaaaaaaa
@skull132 skull132 removed the Feedback Required The PR requires a feedback topic and feedback on the forum. label Jul 19, 2018
@XanderDox
Copy link

The issue is @skull132 , most of the things we'll get D-Noticed for reporting on will be cool antaggy events, which means CCIA will be able to do fuck all about Captains abusing this - and I doubt admins will want an additional thing to have to manage punishing.

Copy link
Contributor

@Karolis2011 Karolis2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If management agrees no this, then I am fine.

@skull132 skull132 merged commit 39a6aac into Aurorastation:development Jul 22, 2018
@skull132 skull132 deleted the feature/journalism branch July 22, 2018 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants