Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the order of the give prompt #503

Merged
merged 11 commits into from
Jul 9, 2016
Merged

Changed the order of the give prompt #503

merged 11 commits into from
Jul 9, 2016

Conversation

Bedshaped
Copy link
Contributor

I changed the order of no and yes in the give prompt because it always gets really confusing when you're typing and you accidently auto-refuse something. LOOC gets involved and it's always really frustrating.

@Bedshaped Bedshaped changed the title Fix give Changed the order of the give prompt Jun 29, 2016
@Bedshaped
Copy link
Contributor Author

So why do those old commits keep popping up?

@skull132
Copy link
Contributor

Because you haven't rebased your base branch. Usually it'd be clean and exactly 1:1 with the repo here.

Kind of irrelevant at the moment, though. They'll get removed when I squash the pull request into a single commit.

@NanakoAC
Copy link
Contributor

NanakoAC commented Jul 5, 2016

Does changing the order help?

I thought it said No if you hit N, and yes if you hit Y

@Bedshaped
Copy link
Contributor Author

It makes the keyboard default to Yes if you accidentally hit enter while you're typing to someone who is trying to give you something.

@skull132 skull132 merged commit 3a18172 into Aurorastation:development Jul 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants