Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes Centcomm Junkfood Vending Machines #5190

Merged
merged 12 commits into from Oct 1, 2018

Conversation

BurgerLUA
Copy link
Contributor

@BurgerLUA BurgerLUA commented Aug 27, 2018

Review

Removes the free food vending machines at centcomm.

Feedback Thread: https://forums.aurorastation.org/viewtopic.php?f=18&t=11821

@BotBOREALIS BotBOREALIS added the 🗺️ Mapping - Aurora The PR touches the Aurora map files. label Aug 27, 2018
Copy link
Member

@Arrow768 Arrow768 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically I do not see an issue with it.
However it still needs a discussion if it should be implemented.

Please link the feedback thread you created.

@Arrow768 Arrow768 added the Feedback Required The PR requires a feedback topic and feedback on the forum. label Aug 27, 2018
@BurgerLUA
Copy link
Contributor Author

Done.

@@ -131,6 +131,7 @@
..()
new /obj/item/clothing/mask/breath( src )
new /obj/item/weapon/reagent_containers/inhaler/phoron_special(src)
new /obj/item/weapon/reagent_containers/food/snacks/koisbar_clean(src)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They already got their phoron inhaler, not sure why give vaurca more access to k'ois/phoron at roundstart, feels like this is going against stopping people from spawning with food suggestion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It basically is (hypocritical). If lunch boxes are power gaming by virtue of giving you access to an in-game resource you should normally work for, then this does exactly the same shit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove it then. I was on the fence about adding this in the first place.

@BurgerLUA
Copy link
Contributor Author

Seems like a lot of people have issue with the lunchbox being removed, so I will remove that removal from this pr, and make another PR that refactors how lunchboxes work.

@skull132
Copy link
Contributor

"How lunchboxes work" 🤔

What did he mean by this.

@BurgerLUA
Copy link
Contributor Author

@skull132
Lunchboxes from loadouts will each have their own theme which contains a different assortment of junkfood. The types are: Vegan, Meat Eater, Balanced, and K'ois which can be specifically selected in the loadout menu. Self-explanatory.

@BurgerLUA BurgerLUA changed the title Removes Centcomm Junkfood Vending Machines, Removes Lunchboxes Removes Centcomm Junkfood Vending Machines Aug 27, 2018
@JackBewt
Copy link

JackBewt commented Aug 27, 2018

This will not bring any more interaction to the chef. This will punish the entire station for there not being a chef, or for there not being a botanist to supply the chef quickly and reliably. Nothing in this PR will make anyone have to do anything more than grab food off the counter and keep walking. You are trying to force people to come to you to talk but this will not achieve even that goal.

Reducing player choice in lunchbox customization will also do nothing.

@BurgerLUA
Copy link
Contributor Author

There is no lunchbox customization, currently. It's completely random. I'm actually adding more customization so I don't know what on earth you're talking about.

@JackBewt
Copy link

It's not completely random. You can customise your lunchbox's contents. I always spawn with a jelly sandwich, candy apple, and bottle of water because I chose those to spawn in my lunchbox in character customization.

You are wrong, and now I am not sure you have tried to use the lunchbox feature yourself?

@BurgerLUA
Copy link
Contributor Author

Nope, someone told me it's customizable. I recall several months back people were complaining that their mom packed them k'ois waffles. I'll just limit it to junkfood.

@JackBewt
Copy link

why are you coding a nerf based on something someone told you a month ago when you don't even know how the current feature works.....

@ProbablyMenown
Copy link
Contributor

Many of the Vaurca players use the vendor for kois bars. This might be a bit iffy, since nothing is being changed regarding kois for them.

@BurgerLUA
Copy link
Contributor Author

The chef can provide Vaurca with filtered kois, and their phoron inhaler is pretty strong. If they run out of phoron ever, they can purchase a k'ois bar or seek assistance from chemistry.

@ProbablyMenown
Copy link
Contributor

@BurgerLUA So your solution is for Vaurca to go to the vending machine to get more phoron?

@skull132 skull132 added this to the Update October 2018 milestone Sep 7, 2018
Copy link
Member

@Arrow768 Arrow768 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are modifying html/changelogs/.all_changelog.yml
Remove your modifications to that file

@skull132 skull132 merged commit 6c28607 into Aurorastation:development Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Merge 🚫 Do Not Merge Feedback Required The PR requires a feedback topic and feedback on the forum. 🗺️ Mapping - Aurora The PR touches the Aurora map files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants