Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cult runes tweaks #5311

Merged
merged 4 commits into from Sep 24, 2018
Merged

Cult runes tweaks #5311

merged 4 commits into from Sep 24, 2018

Conversation

Alberyk
Copy link
Contributor

@Alberyk Alberyk commented Sep 23, 2018

-you can't write runes on space or open space anymore
-teleporter runes do not work if they are on the central command level
-you can only summon nar'sie on the station's z levels
-improves the code a bit

return

var/turf/T = get_turf(user)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add the admin-z check here aswell

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My original plan was just to stop people from teleporting, you can still have someone write a rune in an admin z-level, like a merchant cultists sending a message or something.

@@ -30,6 +30,12 @@ var/list/sacrificed = list()
if (istype(user, /mob/living))
user.take_overall_damage(5, 0)
qdel(src)

var/turf/T = get_turf(user)
if (T.z in current_map.admin_levels)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move that to the general rune activation to not only limit the teleport rune, but all other runes aswell.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My original plan was just to stop people from teleporting, you can still have someone write a rune in an admin z-level, like a merchant cultists sending a message or something.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I still feel that the ability to use runes on the merchant station should be completely removed.
(For the reasons explained in the topic)
If not, then the summon narnar rune should definitly be restricted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I will make so that you can only summon nar'sie on the station levels.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, you now need to be on one of the station z-levels to summon nar'sie.

@Alberyk Alberyk added this to the Update October 2018 milestone Sep 24, 2018
@Arrow768 Arrow768 merged commit d9e3aba into Aurorastation:development Sep 24, 2018
@Alberyk Alberyk deleted the cult_changes branch April 8, 2019 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants