Gradual Research Part Two #9562
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BotBOREALIS
added
🗺️ Mapping - Aurora
|
!review |
mikomyazaki
force-pushed
the
gradual_research_two
branch
from
030de38
to
c7340f3
Compare
Karolis2011
suggested changes
Aug 3, 2020
Comment on lines
+21
to
+35
| methods: { | ||
| abbreviateNumber(value) { | ||
| let newValue = value; | ||
| const suffixes = ["", "K", "M", "B","T"]; | ||
| let suffixNum = 0; | ||
| while (newValue >= 1000) { | ||
| newValue /= 1000; | ||
| suffixNum++; | ||
| } | ||
|
|
||
| newValue = Math.round(newValue); | ||
|
|
||
| newValue += suffixes[suffixNum]; | ||
| return newValue; | ||
| } |
There was a problem hiding this comment.
It's better to do this as a filter - https://vuejs.org/v2/guide/filters.html
Karolis2011
reviewed
Aug 3, 2020
| <div> | ||
| <h3>Research Levels:</h3> | ||
| <vui-group> | ||
| <vui-group-item v-for="tech in techs" :key="tech" :label="tech.name" v-if="tech.level > 1 || tech.next_level_progress > 0"> |
There was a problem hiding this comment.
computed: {
filterdTechs() {
return this.techs.filter(t => t.level > 1 || t.next_level_progress > 0)
}
}
Alberyk
approved these changes
Aug 27, 2020
NonQueueingMatt
added
the
Changes Required
|
Map conflicts, changes required, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explosions give: Material and Phoron
Slime Cells give: Bluespace, Biological, Magnet
Firing Ranges give: Combat, Biological
Winning Sudoku gives: Data
Tesla Coils give: Engineering, Power
I'm not sure about the numbers for all of these, but playtesting showed that they're relatively sane, but they can be tweaked after playtesting.