Fix game starting SteamVR in replay and/or when switching FPFC #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Dont start OpenXR if SteamVR is not already running, makes FPFC replays not start SteamVR
|
Converting to a draft since not done yet. Aparently some people can fuck around and change the steam dir, so now I gotta write a finder |
|
So I guess that fixes it, also gives the option to dynamically bind to SteamVR as long as fpfc flag is active, however thats kinda whacky so ¯_(ツ)_/¯ |
Man I suck at using git
Auros
requested changes
Jan 1, 2024
Meivyn
reviewed
Jan 5, 2024
Arimodu
commented
Jan 21, 2024
| _siraLog.Debug(Environment.GetCommandLineArgs().Any(s => s.ToLower() == "oculus") ? "Running as vrmode Oculus" : "Running as vrmode Steam"); | ||
| bool startXR = (IsProcessRunning("vrserver") && IsProcessRunning("vrcompositor")) || Environment.GetCommandLineArgs().Any(s => s.ToLower() == "oculus"); // If we're running Oculus, we need to start XR | ||
| if (startXR) InitializeXRLoader(); | ||
| if (IsProcessRunning("vrserver") && IsProcessRunning("vrcompositor")) // Not sure how to check for Oculus if vrmode oculus is not working anymore |
There was a problem hiding this comment.
Realisticaly there is no need to reinitialize openxr, since the game can function fine in FPFC without it, but this makes it impossible for oculus only users to start the game in FPFC and still have the headset bind on toggle...
One way would be to see if there is an oculus specific process that could be checked, but I dont own an oculus headset anymore so I cant see if there is one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix game automatically starting SteamVR when FPFC is switched on or off.
Done by checking if SteamVR is running before initializing OpenXR, if SteamVR is not running, dont initialize OpenXR. This way we even preserve the functionality for people who want to start the game in FPFC and then switch to SteamVR, since in that case user can just start SteamVR anytime along the way manually and it will be bound on next check