This repository has been archived by the owner on Mar 5, 2018. It is now read-only.
Page hero improvs + button margin fix + button mbl size fix + .abstract news item fix #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please can we have a quick chat about these @klepas ?
…core into bugfix/typography-edit
We will be avoiding using latin abbreviations like eg (except where space is an issue), hence the change here. I’ll update this as we revisit content.
|
This i ready for a review @petronbot @hannah-ustwo. |
|
Looks much better @klepas . Ticking off design and PO review. |
|
Should also now address issue #179. |
klepas
changed the title
klepas
changed the title
|
Should also now cater for the use of |
|
Specific things that need testing since it was first reviewed:
|
|
Design team and stake holder review accepted |
|
Oh noes, exceptions! :P |
|
LGTM |
…/gov-au-ui-core into bugfixes/type-and-spacing-improvs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type and spacing improvs for the page header and a fix for #165.
Additional information
Also removes some
@extendsto clean up CSS output.Adds
input[role='button']to the scope for@mixin button-colours.Header hero changes, before:
Header hero changes, after:
The button edits, before:
Button edits, after:
Definition of Done
Content/documentation reviewed by Julian or someone in the Content TeamCross-browser tested against standard browser matrix (TBD)Tested on multiple devices (TBD)Accessibility testing & WCAG2 compliance (manual/auto TBD)Stakeholder/PO review