-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an API function to query for bitcom transaction ids. #77
base: master
Are you sure you want to change the base?
Conversation
…d adding support for API providers with differing features.
I'm not familiar with bitcom, but at first glance this looks pretty good. |
Doc fix from my mobile.
if planaria_token and network == 'main': | ||
self.planaria = Planaria(token=planaria_token) | ||
self.list_of_apis.append(self.planaria) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh ignore my earlier comment. I need to spend the time to actually test this code to understand it better than just reading it...
Sorry. I may have to come back to this next weekend...
What happens if PrivakeKey.get_bitcom_transactions()
is called when there is no planaria token? does that case need to return a human-readable error that they require a token (or something like that)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm having some trouble replying to you here, I'm sorry. I tried to copy the way API keys were used in a pre-existing part of the system. I haven't verified the no-token case; the error may not be clear.
This involved adding support for API providers with differing features.