Skip to content

Commit

Permalink
Improve and unify solium / linting / testing flow
Browse files Browse the repository at this point in the history
  • Loading branch information
ottodevs committed Aug 26, 2018
1 parent b260fa3 commit a62c98a
Show file tree
Hide file tree
Showing 8 changed files with 245 additions and 77 deletions.
37 changes: 37 additions & 0 deletions .soliumrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
{
"extends": "solium:all",
"plugins": ["security"],
"rules": {
"security/no-low-level-calls": "off",
"security/no-inline-assembly": "off",
"emit": "off",
"error-reason": "off",
"imports-on-top": "error",
"variable-declarations": "error",
"array-declarations": "error",
"operator-whitespace": "error",
"conditionals-whitespace": "error",
"comma-whitespace": "error",
"semicolon-whitespace": "error",
"function-whitespace": "error",
"lbrace": "error",
"mixedcase": "error",
"camelcase": "error",
"uppercase": "error",
"no-empty-blocks": "error",
"no-unused-vars": "error",
"quotes": "error",
"blank-lines": "error",
"indentation": "error",
"arg-overflow": ["error", 8],
"whitespace": "error",
"deprecated-suicide": "error",
"pragma-on-top": "error",
"function-order": "error",
"no-constant": "error",
"value-in-payable": "error",
"max-len": "error",
"visibility-first": "error",
"linebreak-style": "error"
}
}
35 changes: 35 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
{
"solidity.soliumRules": {
"security/no-low-level-calls": "off",
"security/no-inline-assembly": "off",
"emit": "off",
"error-reason": "off",
"imports-on-top": "error",
"variable-declarations": "error",
"array-declarations": "error",
"operator-whitespace": "error",
"conditionals-whitespace": "error",
"comma-whitespace": "error",
"semicolon-whitespace": "error",
"function-whitespace": "error",
"lbrace": "error",
"mixedcase": "error",
"camelcase": "error",
"uppercase": "error",
"no-empty-blocks": "error",
"no-unused-vars": "error",
"quotes": "error",
"blank-lines": "error",
"indentation": "error",
"arg-overflow": ["error", 8],
"whitespace": "error",
"deprecated-suicide": "error",
"pragma-on-top": "error",
"function-order": "error",
"no-constant": "error",
"value-in-payable": "error",
"max-len": "error",
"visibility-first": "error",
"linebreak-style": "error"
}
}
49 changes: 33 additions & 16 deletions apps/address-book/.soliumrc.json
Original file line number Diff line number Diff line change
@@ -1,20 +1,37 @@
{
"extends": "solium:recommended",
"extends": "solium:all",
"plugins": ["security"],
"rules": {
"array-declarations": 1,
"blank-lines": 0,
"camelcase": 1,
"deprecated-suicide": 1,
"imports-on-top": 0,
"indentation": ["error", 4],
"lbrace": 0,
"mixedcase": 1,
"no-empty-blocks": 1,
"no-unused-vars": 1,
"operator-whitespace": 1,
"pragma-on-top": 1,
"uppercase": 1,
"variable-declarations": 1,
"whitespace": 1
"security/no-low-level-calls": "off",
"security/no-inline-assembly": "off",
"emit": "off",
"error-reason": "off",
"imports-on-top": "error",
"variable-declarations": "error",
"array-declarations": "error",
"operator-whitespace": "error",
"conditionals-whitespace": "error",
"comma-whitespace": "error",
"semicolon-whitespace": "error",
"function-whitespace": "error",
"lbrace": "error",
"mixedcase": "error",
"camelcase": "error",
"uppercase": "error",
"no-empty-blocks": "error",
"no-unused-vars": "error",
"quotes": "error",
"blank-lines": "error",
"indentation": "error",
"arg-overflow": ["error", 8],
"whitespace": "error",
"deprecated-suicide": "error",
"pragma-on-top": "error",
"function-order": "error",
"no-constant": "error",
"value-in-payable": "error",
"max-len": "error",
"visibility-first": "error",
"linebreak-style": "error"
}
}
36 changes: 26 additions & 10 deletions apps/allocations/.soliumrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,36 @@
"extends": "solium:all",
"plugins": ["security"],
"rules": {
"security/no-low-level-calls": "off",
"security/no-inline-assembly": "off",
"emit": "off",
"error-reason": "off",
"imports-on-top": "error",
"variable-declarations": "error",
"array-declarations": "error",
"blank-lines": "off",
"operator-whitespace": "error",
"conditionals-whitespace": "error",
"comma-whitespace": "error",
"semicolon-whitespace": "error",
"function-whitespace": "error",
"lbrace": "error",
"mixedcase": "error",
"camelcase": "error",
"deprecated-suicide": "error",
"imports-on-top": "error",
"indentation": "error",
"lbrace": "off",
"mixedcase": "off",
"uppercase": "error",
"no-empty-blocks": "error",
"no-unused-vars": "error",
"operator-whitespace": "error",
"quotes": "error",
"blank-lines": "error",
"indentation": "error",
"arg-overflow": ["error", 8],
"whitespace": "error",
"deprecated-suicide": "error",
"pragma-on-top": "error",
"uppercase": "error",
"variable-declarations": "error",
"whitespace": "error"
"function-order": "error",
"no-constant": "error",
"value-in-payable": "error",
"max-len": "error",
"visibility-first": "error",
"linebreak-style": "error"
}
}
49 changes: 32 additions & 17 deletions apps/planning-app-kit/.soliumrc.json
Original file line number Diff line number Diff line change
@@ -1,22 +1,37 @@
{
"extends": "solium:recommended",
"extends": "solium:all",
"plugins": ["security"],
"rules": {
"array-declarations": 1,
"blank-lines": 0,
"camelcase": 1,
"deprecated-suicide": 1,
"imports-on-top": 0,
"indentation": ["error", 4],
"lbrace": 1,
"mixedcase": 1,
"no-empty-blocks": 1,
"no-unused-vars": 1,
"operator-whitespace": 1,
"pragma-on-top": 1,
"security/no-inline-assembly": 0,
"uppercase": 1,
"variable-declarations": 1,
"whitespace": 1
"security/no-low-level-calls": "off",
"security/no-inline-assembly": "off",
"emit": "off",
"error-reason": "off",
"imports-on-top": "error",
"variable-declarations": "error",
"array-declarations": "error",
"operator-whitespace": "error",
"conditionals-whitespace": "error",
"comma-whitespace": "error",
"semicolon-whitespace": "error",
"function-whitespace": "error",
"lbrace": "error",
"mixedcase": "error",
"camelcase": "error",
"uppercase": "error",
"no-empty-blocks": "error",
"no-unused-vars": "error",
"quotes": "error",
"blank-lines": "error",
"indentation": "error",
"arg-overflow": ["error", 8],
"whitespace": "error",
"deprecated-suicide": "error",
"pragma-on-top": "error",
"function-order": "error",
"no-constant": "error",
"value-in-payable": "error",
"max-len": "error",
"visibility-first": "error",
"linebreak-style": "error"
}
}
49 changes: 33 additions & 16 deletions apps/projects/.soliumrc.json
Original file line number Diff line number Diff line change
@@ -1,20 +1,37 @@
{
"extends": "solium:recommended",
"extends": "solium:all",
"plugins": ["security"],
"rules": {
"imports-on-top": 0,
"variable-declarations": 1,
"array-declarations": 1,
"operator-whitespace": 1,
"lbrace": 1,
"mixedcase": 1,
"camelcase": 1,
"uppercase": 1,
"no-empty-blocks": 1,
"no-unused-vars": 1,
"blank-lines": 1,
"indentation": ["error", 4],
"whitespace": 1,
"deprecated-suicide": 1,
"pragma-on-top": 1
"security/no-low-level-calls": "off",
"security/no-inline-assembly": "off",
"emit": "off",
"error-reason": "off",
"imports-on-top": "error",
"variable-declarations": "error",
"array-declarations": "error",
"operator-whitespace": "error",
"conditionals-whitespace": "error",
"comma-whitespace": "error",
"semicolon-whitespace": "error",
"function-whitespace": "error",
"lbrace": "error",
"mixedcase": "error",
"camelcase": "error",
"uppercase": "error",
"no-empty-blocks": "error",
"no-unused-vars": "error",
"quotes": "error",
"blank-lines": "error",
"indentation": "error",
"arg-overflow": ["error", 8],
"whitespace": "error",
"deprecated-suicide": "error",
"pragma-on-top": "error",
"function-order": "error",
"no-constant": "error",
"value-in-payable": "error",
"max-len": "error",
"visibility-first": "error",
"linebreak-style": "error"
}
}
49 changes: 32 additions & 17 deletions apps/range-voting/.soliumrc.json
Original file line number Diff line number Diff line change
@@ -1,22 +1,37 @@
{
"extends": "solium:recommended",
"extends": "solium:all",
"plugins": ["security"],
"rules": {
"imports-on-top": 0,
"variable-declarations": 1,
"array-declarations": 1,
"operator-whitespace": 1,
"lbrace": 1,
"mixedcase": 1,
"camelcase": 1,
"uppercase": 1,
"no-empty-blocks": 1,
"no-unused-vars": 1,
"blank-lines": 1,
"indentation": ["error", 4],
"whitespace": 1,
"deprecated-suicide": 1,
"pragma-on-top": 1,
"security/no-inline-assembly": 0
"security/no-low-level-calls": "off",
"security/no-inline-assembly": "off",
"emit": "off",
"error-reason": "off",
"imports-on-top": "error",
"variable-declarations": "error",
"array-declarations": "error",
"operator-whitespace": "error",
"conditionals-whitespace": "error",
"comma-whitespace": "error",
"semicolon-whitespace": "error",
"function-whitespace": "error",
"lbrace": "error",
"mixedcase": "error",
"camelcase": "error",
"uppercase": "error",
"no-empty-blocks": "error",
"no-unused-vars": "error",
"quotes": "error",
"blank-lines": "error",
"indentation": "error",
"arg-overflow": ["error", 8],
"whitespace": "error",
"deprecated-suicide": "error",
"pragma-on-top": "error",
"function-order": "error",
"no-constant": "error",
"value-in-payable": "error",
"max-len": "error",
"visibility-first": "error",
"linebreak-style": "error"
}
}
18 changes: 17 additions & 1 deletion apps/shared/test-helpers/.soliumrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,36 @@
"extends": "solium:all",
"plugins": ["security"],
"rules": {
"security/no-low-level-calls": "off",
"security/no-inline-assembly": "off",
"emit": "off",
"error-reason": "off",
"imports-on-top": "error",
"variable-declarations": "error",
"array-declarations": "error",
"operator-whitespace": "error",
"conditionals-whitespace": "error",
"comma-whitespace": "error",
"semicolon-whitespace": "error",
"function-whitespace": "error",
"lbrace": "error",
"mixedcase": "error",
"camelcase": "error",
"uppercase": "error",
"no-empty-blocks": "error",
"no-unused-vars": "error",
"quotes": "error",
"blank-lines": "error",
"indentation": "error",
"arg-overflow": ["error", 8],
"whitespace": "error",
"deprecated-suicide": "error",
"pragma-on-top": "error"
"pragma-on-top": "error",
"function-order": "error",
"no-constant": "error",
"value-in-payable": "error",
"max-len": "error",
"visibility-first": "error",
"linebreak-style": "error"
}
}

0 comments on commit a62c98a

Please sign in to comment.