Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add city to AddCustomer and AddShipping, allow for updating payment profile billing address. #41

Closed
wants to merge 2 commits into from

Conversation

drmohundro
Copy link

This would fix #40.

@drmohundro
Copy link
Author

Note that it might be better to add an overload that accepts city so that this change won't be a breaking change. Thoughts?

@bojake
Copy link

bojake commented Oct 29, 2014

I added this to #46

It appears that the only way to get a billing address on a customer
payment profile is on the Add methods (add e-check or add credit card).
I can't see any direct way to update the billing address after the
fact. This commit tries to solve this.
@drmohundro drmohundro changed the title Add city to AddCustomer and AddShipping. Add city to AddCustomer and AddShipping, allow for updating payment profile billing address. Nov 12, 2014
@drmohundro
Copy link
Author

I added another small change to allow for updating the billing address when calling UpdatePaymentProfile - I couldn't see any way to do this after the credit card or e-check are saved.

I'd be happy to squash these commits for a cleaner merge if that helps.

@bojake
Copy link

bojake commented Nov 12, 2014

Yes, even better, consolidate all of these conflicting commits into one. Makes it more likely they will get merged.

@drmohundro
Copy link
Author

Agreed - do you think it makes more sense to put it all in #46 given that you've got more commits?

@totallyeviljake
Copy link

No problem, I can do that.

@totallyeviljake
Copy link

that should do it for this PR. Hopefully someone will merge in the PR soon.

@brianmc
Copy link
Contributor

brianmc commented Dec 10, 2014

We're going to take these two PRs from the combined #46

Thanks guys!

Brian

@brianmc brianmc closed this Dec 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CustomerAddress Missing "City"
4 participants