Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show, app running status and delay info (with tooltip) on the tray icon. #560

Closed
cmhrky opened this issue Oct 16, 2022 · 8 comments
Closed
Labels
enhancement New feature or request

Comments

@cmhrky
Copy link
Contributor

cmhrky commented Oct 16, 2022

Describe the enhancement or feature you'd like
It will allow you to quickly learn the relevant information without opening the application interface.

Describe alternatives you've considered
Gray ADM icon if app is disabled.
The app icon with the pause icon when paused.
App status and "Active delays" information in the tooltip.

Additional context
image
image
image

@cmhrky cmhrky added the enhancement New feature or request label Oct 16, 2022
@Spiritreader
Copy link
Member

I don't know if we can implement this in time for the 10.3 release, but that's a super cool idea.
I really like this.

@tooomm
Copy link
Contributor

tooomm commented Oct 16, 2022

Ha, I had a very similar idea to improve the tray icon a few days ago @cmhrky! 😄

My thoughts were to also highlight the mode that is currently used in the tray icon, like:

  • In light mode:
    For example, show the sun part of the icon with colors, and the moon part in gray
  • In dark mode:
    For example, show the moon part of the icon with colors, and the sun part in gray

Or use dedicated icons for it (e.g. light: sun / dark: moon).

Showing that automatic switching is paused (pause symbol overlay) or disabled (all gray icon), as you suggested, can be combined with it as well.

Spiritreader added a commit that referenced this issue Oct 16, 2022
- implements #560
- add trace option to dump active theme file content
@cmhrky
Copy link
Contributor Author

cmhrky commented Oct 16, 2022

You are so fast. Thanks. Will there be tooltip information?

@Armin2208
Copy link
Member

wow respect for this suggestion, awesome

@Spiritreader
Copy link
Member

Spiritreader commented Oct 16, 2022

You are so fast. Thanks. Will there be tooltip information?

I will play around with it, but no guarantees that it will make it into a final build.
That's also a bit more complex to do because of translation strings and formatting and would take a bit longer.

@cmhrky
Copy link
Contributor Author

cmhrky commented Oct 20, 2022

If AutoDarkModeSvc.exe is restarted while ADM is disabled, the tray icon appears to be enabled.

Also, if there is an active delay set manually, it will be canceled on the next restart. I don't know the status of the Tray icon.

@Spiritreader
Copy link
Member

Spiritreader commented Oct 20, 2022

the tray icon appears to be enabled.

Oh yes, it doesn't update this. will fix

Also, if there is an active delay set manually, it will be canceled on the next restart.

That is intentional.

@Spiritreader
Copy link
Member

Spiritreader commented Oct 22, 2022

You are so fast. Thanks. Will there be tooltip information?

There will be tooltip information in the next build!
It'll be more rudimentary than when opening the context menu but will provide some info about ADM's current theme state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants