Passive Customization Attributes are ignored when used in combination with [Frozen]

[sshushliapin]

If a test method parameter is decorated with both [Substitute] and [Frozen] attributes, a concrete instance is created instead of a substitute. The following test fails:

[Theory, AutoNSubstituteData]
public void FreezeConcreteTypeSubstitute([Frozen, Substitute] ConcreteType ct1, ConcreteType ct2)
{
    Assert.Same(ct1, ct2);
    Assert.True(ct1.GetType().BaseType == typeof(ConcreteType)); // fails
    // A real instance is created instead of a mock.
}

The issue has been addressed in PR #627 but it was agreed that the solution is sub-optimal. To be implemented in a new PR.

[ploeh]

@sergeyshushlyapin, while I haven't added the jump in label to this issue, you're still more than welcome to attempt to address it. You seem to be on top of things 👍

[sshushliapin]

The issue is not about the [Substitute] attribute only. It's about all the Passive Attributes that require corresponding relays to create specimens (e.g. StringLengthAttributeRelay):

[Theory, AutoData]
public void StringLengthConstraintWorksWithoutFrozen([StringLength(3)]string str)
{
    Assert.True(str.Length == 3); // pass
}

[Theory, AutoData]
public void StringLengthConstraintFailsWithFrozen([Frozen][StringLength(3)]string str)
{
    Assert.True(str.Length == 3); // fails
}

The underlying reason is in the wrong assumption that in order to create a specimen only type is required. In the Glue Libraries specimens can be defined by types and Customization Attributes.

The FreezeOnMatchCustomization resolves specimens using type only which causes the issue:

var specimen = context.Resolve(this.TargetType);

[zvirja]

Just a hint: as a potential way to fix this issue is to create a custom ICustomAttributeProvider implementation and resolve it. That implementation should hide one attribute that we already processed. However, that could lead to large refactoring for existing code..

Update: disregard the comment above, I misunderstood the root of the issue.

[zvirja]

Will be fixed in v4.