Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Stylecop analysis #1037

Merged
merged 75 commits into from Jun 4, 2018
Merged

Enable Stylecop analysis #1037

merged 75 commits into from Jun 4, 2018

Commits on May 24, 2018

  1. Enable StyleCop

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    ebc6053 View commit details
    Browse the repository at this point in the history

  2. Ignore all applicable StyleCop violations

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    be07b6a View commit details
    Browse the repository at this point in the history

  3. Fix SA1505: An opening brace should not be followed by a blank line

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    9ff02e3 View commit details
    Browse the repository at this point in the history

  4. Fix SA1507: Code should not contain multiple blank lines in a row

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    65d3f0e View commit details
    Browse the repository at this point in the history

  5. Fix SA1508: A closing brace should not be preceded by a blank line

    @zvirja
    zvirja committed May 24, 2018
    Copy the full SHA
    9f9e35b View commit details
    Browse the repository at this point in the history

  6. Fix SA1509: Opening braces should not be preceded by blank line

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    9d3ebbc View commit details
    Browse the repository at this point in the history

  7. Fix SA1512: Single-line comments should not be followed by blank line

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    9e4d0c6 View commit details
    Browse the repository at this point in the history

  8. Fix SA1514: Element documentation header should be preceded by blank … 

    …line
    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    7ad21ba View commit details
    Browse the repository at this point in the history

  9. Fix SA1516: Elements should be separated by blank line

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    0adc65d View commit details
    Browse the repository at this point in the history

  10. Fix SA1518: Code should not contain blank lines at the end of the file

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    bdd1adb View commit details
    Browse the repository at this point in the history

  11. Fix SA1000: Keywords must be spaced correctly

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    bf40b40 View commit details
    Browse the repository at this point in the history

  12. Fix SA1001: Commas must be spaced correctly

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    871ae71 View commit details
    Browse the repository at this point in the history

  13. Fix SA1002: Semicolons should be followed by a space

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    7e3a60b View commit details
    Browse the repository at this point in the history

  14. Fix SA1003: Symbols must be spaced correctly

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    2017be7 View commit details
    Browse the repository at this point in the history

  15. Fix SA1004: Documentation line should begin with a space

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    5e819bc View commit details
    Browse the repository at this point in the history

  16. Fix SA1005: Single line comment should begin with a space

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    8ec6b6c View commit details
    Browse the repository at this point in the history

  17. Fix SA1008: Opening parenthesis should not be followed by a space

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    351df50 View commit details
    Browse the repository at this point in the history

  18. Fix SA1009: Closing parenthesis must be spaced correctly

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    14d3fd6 View commit details
    Browse the repository at this point in the history

  19. Fix SA1011: Closing square bracket should be followed by a space

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    77ab40b View commit details
    Browse the repository at this point in the history

  20. Fix SA1012: Opening brace should be followed by a space

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    5e0825e View commit details
    Browse the repository at this point in the history

  21. Fix SA1013: Closing brace should be preceded by a space

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    df9a0e9 View commit details
    Browse the repository at this point in the history

  22. Fix SA1015: Closing generic bracket should be followed by a space

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    7e32f92 View commit details
    Browse the repository at this point in the history

  23. Stop suppressing SA1021: Negative sign should be preceded by a space

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    dc7e1e2 View commit details
    Browse the repository at this point in the history

  24. Fix SA1024: Colon should be preceded by a space

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    43fcb86 View commit details
    Browse the repository at this point in the history

  25. Partially fix SA1025: Code should not contain multiple whitespace cha… 

    …racters in a row
    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    e66acbd View commit details
    Browse the repository at this point in the history

  26. Fix SA1026: The keyword 'new' should not be followed by a space or a … 

    …blank line
    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    5c880dd View commit details
    Browse the repository at this point in the history

  27. Fix SA1027: Tabs and spaces should be used correctly

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    4241421 View commit details
    Browse the repository at this point in the history

  28. Fix SA1028: Code should not contain trailing whitespace

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    577f267 View commit details
    Browse the repository at this point in the history

  29. Fix SA1101: Prefix local calls with this

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    d17980b View commit details
    Browse the repository at this point in the history

  30. Fix SA1106: Code should not contain empty statements

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    b088136 View commit details
    Browse the repository at this point in the history

  31. Fix SA1107: Code should not contain multiple statements on one line

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    2667aea View commit details
    Browse the repository at this point in the history

  32. Fix SA1110: Opening parenthesis or bracket should be on declaration line

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    1c71a1f View commit details
    Browse the repository at this point in the history

  33. Stop suppressing SA1111: Closing parenthesis should be on line of las… 

    …t parameter
    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    ca0e79a View commit details
    Browse the repository at this point in the history

  34. Fix SA1114: Parameter list should follow declaration

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    57ff4a9 View commit details
    Browse the repository at this point in the history

  35. Fix SA1115: The parameter should begin on the line after the previous… 

    … parameter
    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    d596d5d View commit details
    Browse the repository at this point in the history

  36. Fix SA1119: Statement should not use unnecessary parenthesis

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    a89ae87 View commit details
    Browse the repository at this point in the history

  37. Fix SA1121: Use built-in type alias

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    87ee0b9 View commit details
    Browse the repository at this point in the history

  38. Fix SA1122: Use string.Empty for empty strings

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    09ae115 View commit details
    Browse the repository at this point in the history

  39. Fix SA1124: Do not use regions

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    02199a9 View commit details
    Browse the repository at this point in the history

  40. Fix SA1125: Use shorthand for nullable types

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    6bd92a7 View commit details
    Browse the repository at this point in the history

  41. Fix SA1127: Generic type constraints should be on their own line

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    ac497b1 View commit details
    Browse the repository at this point in the history

  42. Fix SA1128: Put constructor initializers on their own line

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    b2f462d View commit details
    Browse the repository at this point in the history

  43. Fix SA1129: Do not use default value type constructor

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    fe5ef91 View commit details
    Browse the repository at this point in the history

  44. Fix SA1130: Use lambda syntax

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    1d78ef3 View commit details
    Browse the repository at this point in the history

  45. Fix SA1131: Constant values should appear on the right-hand side of c… 

    …omparisons
    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    5200282 View commit details
    Browse the repository at this point in the history

  46. Fix SA1133: Each attribute should be placed in its own set of square … 

    …brackets
    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    1531d2b View commit details
    Browse the repository at this point in the history

  47. Fix SA1136: Enum values should be on separate lines

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    91aa929 View commit details
    Browse the repository at this point in the history

  48. Fix SA1137: Elements should have the same indentation

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    b3a562d View commit details
    Browse the repository at this point in the history

  49. Fix SA1139: Use literal suffix notation instead of casting

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    3a32c5b View commit details
    Browse the repository at this point in the history

  50. Fix SA1210: Using directives should be ordered alphabetically by the … 

    …namespaces
    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    1f0aca6 View commit details
    Browse the repository at this point in the history

  51. Fix SA1300: Element must begin with uppercase letter

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    b3fc332 View commit details
    Browse the repository at this point in the history

  52. Fix SA1307: Accessible field should begin with upper-case letter

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    73c049b View commit details
    Browse the repository at this point in the history

  53. Fix SA1309: Field names must not begin with underscore

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    d8986f8 View commit details
    Browse the repository at this point in the history

  54. SA1310 Field names must not contain an underscore

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    05c78ae View commit details
    Browse the repository at this point in the history

  55. SA1311: Static readonly fields should begin with upper-case letter

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    77baedc View commit details
    Browse the repository at this point in the history

  56. SA1312: Variable names should begin with lower-case letter

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    0572eea View commit details
    Browse the repository at this point in the history

  57. Fix SA1313: Parameter '_' should begin with lower-case letter

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    5e7efb0 View commit details
    Browse the repository at this point in the history

  58. Fix SA1314: Type parameter names should begin with T

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    cff5486 View commit details
    Browse the repository at this point in the history

  59. Fix SA1400: Elements should declare an access modifier

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    518773a View commit details
    Browse the repository at this point in the history

  60. Fix SA1401: Field should be private

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    7020cb2 View commit details
    Browse the repository at this point in the history

  61. Fix SA1402: File may only contain a single type

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    f649bf9 View commit details
    Browse the repository at this point in the history

  62. Fix SA1404: Code analysis suppression should have justification

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    aaa5e91 View commit details
    Browse the repository at this point in the history

  63. Fix SA1407: Arithmetic expressions should declare precedence

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    6c08fc4 View commit details
    Browse the repository at this point in the history

  64. Fix SA1408: Conditional expressions should declare precedence

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    42652cd View commit details
    Browse the repository at this point in the history

  65. Fix SA1500: Braces for multi-line statements should not share line

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    75e17bb View commit details
    Browse the repository at this point in the history

  66. Fix SA1502: Element should not be on a single line

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    c833833 View commit details
    Browse the repository at this point in the history

  67. Fix SA1504: All accessors should be single-line or multi-line

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    e462336 View commit details
    Browse the repository at this point in the history

  68. Suppress only in tests SA1515: Single-line comment should be preceded… 

    … by blank line
    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    31ee03b View commit details
    Browse the repository at this point in the history

  69. Fix SA1519: Braces should not be omitted from multi-line child statement

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    af3dd3b View commit details
    Browse the repository at this point in the history

  70. Fix SA1649: File name should match first type name

    @blairconrad @zvirja
    blairconrad authored and zvirja committed May 24, 2018
    Copy the full SHA
    8399c06 View commit details
    Browse the repository at this point in the history

  71. Fix SA0001: XML comment analysis is disabled due to project configura… 

    …tion
    @zvirja
    zvirja committed May 24, 2018
    Copy the full SHA
    1107293 View commit details
    Browse the repository at this point in the history

  72. Fix SA1629: Documentation text should end with a period

    @zvirja
    zvirja committed May 24, 2018
    Copy the full SHA
    6b5ff2e View commit details
    Browse the repository at this point in the history

  73. Rename ruleset files to better describe their content

    @zvirja
    zvirja committed May 24, 2018
    Copy the full SHA
    2d7a58f View commit details
    Browse the repository at this point in the history

Commits on May 26, 2018

  1. Disable code analysis for non-verification build 

    The main aim is to improve IDE performance when
writing the code.
    @zvirja
    zvirja committed May 26, 2018
    Copy the full SHA
    5373c6e View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2018

  1. Add a diagnostics hint to the validation failure message

    @zvirja
    zvirja committed Jun 4, 2018
    Copy the full SHA
    349e4c3 View commit details
    Browse the repository at this point in the history