Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ConstructorInitializedMemberAssertion false positive for bool arguments #1236

Merged
merged 3 commits into from
Mar 8, 2021

Conversation

aivascu
Copy link
Member

@aivascu aivascu commented Feb 21, 2021

Changes

  • Fixes ConstructorInitializedMemberAssertion false positive results for bool constructor parameters occurring at even positions

fixes #1235

@aivascu aivascu requested a review from zvirja February 21, 2021 10:05
@aivascu aivascu force-pushed the issue-1235 branch 3 times, most recently from 30c6f45 to 540cb6e Compare February 21, 2021 19:46
Copy link
Member

@zvirja zvirja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Dropped a single comment about one-liner condition style in conjunction with return statements.

Src/Idioms/ConstructorInitializedMemberAssertion.cs Outdated Show resolved Hide resolved
@aivascu aivascu merged commit 359a3b0 into AutoFixture:master Mar 8, 2021
@aivascu aivascu deleted the issue-1235 branch March 8, 2021 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Idioms: ConstructorInitializedMemberAssertion returns false positive in case of bool types
2 participants