Migrate Idioms.FsCheck to support .NET Standard #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moodmosaic
approved these changes
Dec 15, 2017
| @@ -0,0 +1 @@ | |||
| 锘縨odule Program = let [<EntryPoint>] main _ = 0 | |||
There was a problem hiding this comment.
I'm curious to find out why we have to do this for a Class Library project.
There was a problem hiding this comment.
As far as I got it, test project for the .NET Core is not a library, rather it's an application. The key point is that the default template for the .NET Core test project includes this file.
You can find more detail here (that is the error I met):
dotnet/fsharp#2669
dotnet/netcorecli-fsc#79
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #880.
Visual Studio 2017 Update 5 improved .NET Core support for F#, allowing to migrate the leftover FsCheck project to F#.
Nothing changed in the code, except added dependency.
@moodmosaic Please take a look 馃槈