-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/wizard #553
Feat/wizard #553
Conversation
…rary construction
…rkflows have been removed
Certificate is expired
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really nice! I cannot wait to try it out in the next release.
I made some small comments that can be ignored at your discretion.
@@ -31,6 +31,8 @@ jobs: | |||
apt-get install -y python3-sphinx python3-breathe python3-sphinx-rtd-theme sphinx-doc doxygen-latex doxygen-doc gsfonts graphviz-doc libgd-tools xapian-tools && | |||
pip3 install exhale && | |||
pip3 install -r tools/smartpeak/requirements.txt | |||
apt remove cmake | |||
pip3 install cmake --upgrade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is annoying the default cmake is behind the version needed...
Unprotect-Cert '.\CodeSigning\CodeSigning_DTU_AIT_KIT_DTUDOC.pfx.AES' -KeyAsPlainText $env:PFX_AES -RemoveSource | ||
certutil -p $env:PFX_PSWD -importpfx .\CodeSigning\CodeSigning_DTU_AIT_KIT_DTUDOC.pfx | ||
& 'C:\Program Files (x86)\windows kits\10\bin\x64\signtool.exe' sign /v /sm /s My /n "DTU-AIT-DTUDOC client Plugin" *.exe | ||
# - run: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to keep it commented instead of deleting.
split_window.setupLayoutLoader(layout_loader); | ||
|
||
// We need titles for all sub windows | ||
checkTitles(split_window.top_windows_); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the checkTitles
method needed or can it be removed?
/** | ||
* @brief list all windows ptr to be used in the Presets layout | ||
*/ | ||
struct AllWindows final |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -111,4 +133,38 @@ namespace SmartPeak | |||
ImGui::PopStyleVar(); | |||
return; | |||
} | |||
|
|||
void SplitWindow::resetLayout(const std::map<std::string, std::vector<std::tuple<std::shared_ptr<Widget>, bool>>>& layout) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
The statistic Widget is perhaps still sensible to some action, like changing selection when the workflow is running; But the basic use case is fixed.