Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/wizard #553

Merged
merged 26 commits into from
Jan 11, 2023
Merged

Feat/wizard #553

merged 26 commits into from
Jan 11, 2023

Conversation

bertrandboudaud
Copy link
Collaborator

  • Introduced Preset Workflow
  • Fixed bug with Statistic Widget

The statistic Widget is perhaps still sensible to some action, like changing selection when the workflow is running; But the basic use case is fixed.

Copy link
Collaborator

@dmccloskey dmccloskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really nice! I cannot wait to try it out in the next release.

I made some small comments that can be ignored at your discretion.

@@ -31,6 +31,8 @@ jobs:
apt-get install -y python3-sphinx python3-breathe python3-sphinx-rtd-theme sphinx-doc doxygen-latex doxygen-doc gsfonts graphviz-doc libgd-tools xapian-tools &&
pip3 install exhale &&
pip3 install -r tools/smartpeak/requirements.txt
apt remove cmake
pip3 install cmake --upgrade
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is annoying the default cmake is behind the version needed...

Unprotect-Cert '.\CodeSigning\CodeSigning_DTU_AIT_KIT_DTUDOC.pfx.AES' -KeyAsPlainText $env:PFX_AES -RemoveSource
certutil -p $env:PFX_PSWD -importpfx .\CodeSigning\CodeSigning_DTU_AIT_KIT_DTUDOC.pfx
& 'C:\Program Files (x86)\windows kits\10\bin\x64\signtool.exe' sign /v /sm /s My /n "DTU-AIT-DTUDOC client Plugin" *.exe
# - run:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to keep it commented instead of deleting.

split_window.setupLayoutLoader(layout_loader);

// We need titles for all sub windows
checkTitles(split_window.top_windows_);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the checkTitles method needed or can it be removed?

/**
* @brief list all windows ptr to be used in the Presets layout
*/
struct AllWindows final
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -111,4 +133,38 @@ namespace SmartPeak
ImGui::PopStyleVar();
return;
}

void SplitWindow::resetLayout(const std::map<std::string, std::vector<std::tuple<std::shared_ptr<Widget>, bool>>>& layout)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bertrandboudaud bertrandboudaud merged commit 6556418 into develop Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants