Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop netstandard13 #2804

Merged
merged 4 commits into from
Sep 24, 2018
Merged

Drop netstandard13 #2804

merged 4 commits into from
Sep 24, 2018

Conversation

jbogard
Copy link
Member

@jbogard jbogard commented Sep 23, 2018

And rev up to net461 based on MS recommendation. Basically, net461 has an issue with netstandard2.0, so we should target it explicitly.

This should simplify our dependencies, and fix folks that have to do weird binding redirects with ValueTuple.

@jbogard jbogard added this to the v.Next milestone Sep 23, 2018
@lbargaoanu
Copy link
Member

We don't support 4.5 anymore.
4.7 projects will use the 4.6.1 target and they will still have a reference to ValueTuple.
Platforms that don't support Reflection.Emit will have a reference to it.
Problematic I'd say.

@jbogard
Copy link
Member Author

jbogard commented Sep 24, 2018

Here's the recommendation: https://twitter.com/terrajobst/status/1040410118053982208

@lbargaoanu
Copy link
Member

I guess 4.5 is old and the value tuple thing is a framework problem. So replacing 4.5 with 4.6.1 might not be a big deal. But I don't know how mobile platforms wil handle Reflection.Emit.

@jbogard
Copy link
Member Author

jbogard commented Sep 24, 2018

@lbargaoanu They won't. They'll just get a PlatformNotSupportedException. Not much to do about it, basically the .NET team restored the reflection package back into netstandard2.0 with the expectation that you just don't use those features in platforms that don't support it. I don't really want to create targets for all the mobile platforms since all we'd do is throw our own exception in those cases.

@jbogard jbogard merged commit 4ee9a20 into master Sep 24, 2018
@jbogard jbogard deleted the drop-netstandard13 branch September 24, 2018 14:39
@lbargaoanu
Copy link
Member

Reflection.Emit is part of .Net Standard 2.1.

@lock
Copy link

lock bot commented May 5, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants