Container Tests Refactoring

[HobbyProgrammer]

Description

Refactors the tests of the containers to remove duplicate code.

TODO:

• Pull together common tests for all containers
• Write generic ContainerVersusContainer test and use it for all versus tests.
• Check globals in TraversalComparison
• Check halo particles
• Check slight moves
• Cell size factors

not done

• Pull together common tests for all Verlet lists containers
• Check that Verlet-like containers need at most as many flops as others these tests have now actually been removed.

Fixes

• fixes incorrect calculation of globals when using the ClusterFunctor.
• fixes incorrect calculation of globals when using the LJFunctorCudaGlobals and more than 64 particles per cell.
• fixes C01CudaTraversal claiming to be applicable for cellLengths < interactionLength, see also cellsize support < 1.0 for C01CudaTraversal #417
• fixes incorrect calculation of energy in LJFunctorCudaGlobals. only bodyBodyFN3, i.e., cell pairs and newton3 and interactions with halo particles.
• fixes misplaced __syncthreads() in SoAFunctorN3Pair() of LJFunctorCuda(Globals).cu

hotfixes

• disables sorting, see Sorting is broken #418
• does not test cuda c01 for very high densities, see Cuda: LJFunctors throw exceptions at VERY high densities #419
• disables C01CudaTraversal for enabled newton3, see C01CudaTraversal is incorrect when using Newton3 and Halo Particles are present #420
• disables C04SoATraversal completely, see C04SoA traversal produces wrong results when using Halo particles #422, support non-cell-wise owned state #423

Related Pull Requests

None

Resolved Issues

• closes C04SoA Traversal is not compared with others in tests #309 (8d3f289 implements base step comparison with C08, a9403fa compares C04SoA with other traversals using many particles (100+) )

How Has This Been Tested?

This adds lots of tests.

Notes

The gtest_discover_tests does now take more than a minute. I have submitted a merge request to fix this:
https://gitlab.kitware.com/cmake/cmake/merge_requests/4371

[HobbyProgrammer]

For the generic ContainerVersusContainer test:

• Should this be run for all traversals or only for the containers?
• How should the kernel call and distance calculation count checks be build into these generic tests, as there are several exceptions depending on the traversal or container?

[HobbyProgrammer]

For the common tests for all containers:

• How much can isContainerUpdateNeeded() be tested generically? Is there something else than testing than a container update is needed if a particle moves to halo?

[Garfield96]

As far as I know, @SteffenSeckler wants to extend the AutoPasInterfaceTest to test 2 containers against each other. A basic version is already there.

[HobbyProgrammer]

As far as I know, @SteffenSeckler wants to extend the AutoPasInterfaceTest to test 2 containers against each other. A basic version is already there.

I think these tests will only test the containers with very few particles against each other. Correct me if I am wrong @SteffenSeckler.