Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect PointInstancer instance rotations #1776

Closed
cpichard opened this issue Dec 6, 2023 · 2 comments
Closed

Incorrect PointInstancer instance rotations #1776

cpichard opened this issue Dec 6, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@cpichard
Copy link
Collaborator

cpichard commented Dec 6, 2023

Describe the bug
The "orientations" parameter of the PointInstancer does not seem to be converted to the correct rotation in the render delegate. When we change its value, the affected object does not move or rotate in the render delegate when it does with the procedural and storm.

@cpichard cpichard added the bug Something isn't working label Dec 6, 2023
@autodesk-oss-arnold-bot
Copy link

Issue synced internally to ARNOLD-14525

cpichard added a commit to cpichard/arnold-usd that referenced this issue Dec 6, 2023
cpichard added a commit to cpichard/arnold-usd that referenced this issue Dec 6, 2023
cpichard added a commit that referenced this issue Dec 8, 2023
…render delegate (#1777)

* add test for #1776

* Initialize the rotation matrix with the quad directly

* update changelog for #1776
sebastienblor added a commit that referenced this issue Jan 3, 2024
* Update tests after arnold changes on curves (#1766)

(cherry picked from commit 2fcc262)

* Fix the incorrect orientation of the PointInstancer instances in the render delegate (#1777)

* add test for #1776

* Initialize the rotation matrix with the quad directly

* update changelog for #1776

* Fix changelog for 7.2.5 release

---------

Co-authored-by: cpichard <cpichard@users.noreply.github.com>
@autodesk-oss-arnold-bot
Copy link

Issue synced internally to ARNOLD-14580

cpichard added a commit that referenced this issue Jan 25, 2024
* Update tests after arnold changes on curves (#1766)

(cherry picked from commit 2fcc262)

* Fix the incorrect orientation of the PointInstancer instances in the render delegate (#1777)

* add test for #1776

* Initialize the rotation matrix with the quad directly

* update changelog for #1776

* Fix changelog for 7.2.5 release (#1788)

* More changelog fixes

* handle vertex interpolated uvs on bspline curves (#1792)

* FIx the error "Cannot load _htoa_pygeo library required for volume rendering in Solaris" (#1811)

* Improve material network creation times by caching the nodes returned by Arnold (#1813)

* Improve material network creation by caching the nodes returned by arnold

* optimize further by first checking if the shader is an arnold shader

* move shader node entry and osl code cache in the render delegate and use lock/mutex

* cache materialx nodes only

* Fix build with older versions of arnold (#1820)

* fix build with older versions of arnold

* fix compatibility with older versions of arnold

* convert AtString to string

* allow materialx for versions > 7.1.4

* fix ifdef versions for materialx

* compatibility with older arnold versions

---------

Co-authored-by: Sebastien Blaineau-Ortega <sebastien.blaineau.ortega@autodesk.com>
cpichard added a commit that referenced this issue Jan 25, 2024
* Update tests after arnold changes on curves (#1766)

(cherry picked from commit 2fcc262)

* Fix the incorrect orientation of the PointInstancer instances in the render delegate (#1777)

* add test for #1776

* Initialize the rotation matrix with the quad directly

* update changelog for #1776

* Fix changelog for 7.2.5 release (#1788)

* More changelog fixes

* handle vertex interpolated uvs on bspline curves (#1792)

* FIx the error "Cannot load _htoa_pygeo library required for volume rendering in Solaris" (#1811)

* Improve material network creation times by caching the nodes returned by Arnold (#1813)

* Improve material network creation by caching the nodes returned by arnold

* optimize further by first checking if the shader is an arnold shader

* move shader node entry and osl code cache in the render delegate and use lock/mutex

* cache materialx nodes only

* Fix build with older versions of arnold (#1820)

* fix build with older versions of arnold

* fix compatibility with older versions of arnold

* convert AtString to string

* allow materialx for versions > 7.1.4

* fix ifdef versions for materialx

* compatibility with older arnold versions

* update changelog for fix-7.2.5.0 (#1827)

* Fix crash happening in maya aiStandin when scrolling the timeline (#1830)

* make the UsdArnoldReaderRegistry non static

* register readers before reading

---------

Co-authored-by: Sebastien Blaineau-Ortega <sebastien.blaineau.ortega@autodesk.com>
sebastienblor added a commit that referenced this issue Feb 15, 2024
* Update tests after arnold changes on curves (#1766)

(cherry picked from commit 2fcc262)

* Fix the incorrect orientation of the PointInstancer instances in the render delegate (#1777)

* add test for #1776

* Initialize the rotation matrix with the quad directly

* update changelog for #1776

* Fix changelog for 7.2.5 release (#1788)

* More changelog fixes

* handle vertex interpolated uvs on bspline curves (#1792)

* FIx the error "Cannot load _htoa_pygeo library required for volume rendering in Solaris" (#1811)

* Improve material network creation times by caching the nodes returned by Arnold (#1813)

* Improve material network creation by caching the nodes returned by arnold

* optimize further by first checking if the shader is an arnold shader

* move shader node entry and osl code cache in the render delegate and use lock/mutex

* cache materialx nodes only

* Fix build with older versions of arnold (#1820)

* fix build with older versions of arnold

* fix compatibility with older versions of arnold

* convert AtString to string

* allow materialx for versions > 7.1.4

* fix ifdef versions for materialx

* compatibility with older arnold versions

* update changelog for fix-7.2.5.0 (#1827)

* Fix crash happening in maya aiStandin when scrolling the timeline (#1830)

* make the UsdArnoldReaderRegistry non static

* register readers before reading

* Convert the ArnoldProceduralCustom transform matrix to Arnold in the procedural code (#1832)

* read the matrix in the ArnoldProceduralCustom procedural reader

* update test_0739 reference image

* rename unrelease to fix-7.2.5 to follow master convention (#1843)

* Update tests after core changes in fix-7.2.5 (#1849)

* Changed HtoAConvertPrimVdbToArnold symbol lookup from pythonX.Xlibs/_htoa_pygeo lookup to scripts/bin/htoa_geo.dll (#1850)

* update fix-7.2.5 changelog for 7.2.5.2 (#1856)

* update fix-7.2.5 changelog for 7.2.5.2

* correct version

* Fix merge conflict

* Temporarily remove test_0202 from the hydra group

* Fix slowness in the render delegate due to scene update when the camera moves (#1855)

* fix the test of the camera type

* update changelog

* merge and fix changelog

* Remove legacy code

* Fixing changelog

* Fix indentation

---------

Co-authored-by: cpichard <cpichard@users.noreply.github.com>
Co-authored-by: Tom Minor <5022079+TomMinor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants