Convert the ArnoldProceduralCustom transform matrix to Arnold in the procedural code #1832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienblor
approved these changes
Jan 26, 2024
sebastienblor
added a commit
that referenced
this pull request
Feb 15, 2024
* Update tests after arnold changes on curves (#1766) (cherry picked from commit 2fcc262) * Fix the incorrect orientation of the PointInstancer instances in the render delegate (#1777) * add test for #1776 * Initialize the rotation matrix with the quad directly * update changelog for #1776 * Fix changelog for 7.2.5 release (#1788) * More changelog fixes * handle vertex interpolated uvs on bspline curves (#1792) * FIx the error "Cannot load _htoa_pygeo library required for volume rendering in Solaris" (#1811) * Improve material network creation times by caching the nodes returned by Arnold (#1813) * Improve material network creation by caching the nodes returned by arnold * optimize further by first checking if the shader is an arnold shader * move shader node entry and osl code cache in the render delegate and use lock/mutex * cache materialx nodes only * Fix build with older versions of arnold (#1820) * fix build with older versions of arnold * fix compatibility with older versions of arnold * convert AtString to string * allow materialx for versions > 7.1.4 * fix ifdef versions for materialx * compatibility with older arnold versions * update changelog for fix-7.2.5.0 (#1827) * Fix crash happening in maya aiStandin when scrolling the timeline (#1830) * make the UsdArnoldReaderRegistry non static * register readers before reading * Convert the ArnoldProceduralCustom transform matrix to Arnold in the procedural code (#1832) * read the matrix in the ArnoldProceduralCustom procedural reader * update test_0739 reference image * rename unrelease to fix-7.2.5 to follow master convention (#1843) * Update tests after core changes in fix-7.2.5 (#1849) * Changed HtoAConvertPrimVdbToArnold symbol lookup from pythonX.Xlibs/_htoa_pygeo lookup to scripts/bin/htoa_geo.dll (#1850) * update fix-7.2.5 changelog for 7.2.5.2 (#1856) * update fix-7.2.5 changelog for 7.2.5.2 * correct version * Fix merge conflict * Temporarily remove test_0202 from the hydra group * Fix slowness in the render delegate due to scene update when the camera moves (#1855) * fix the test of the camera type * update changelog * merge and fix changelog * Remove legacy code * Fixing changelog * Fix indentation --------- Co-authored-by: cpichard <cpichard@users.noreply.github.com> Co-authored-by: Tom Minor <5022079+TomMinor@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Issues fixed in this pull request
Fixes #1753