Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aborted render should mark render pass as converged #4

Closed
nrusch opened this issue Nov 12, 2019 · 0 comments · Fixed by #309
Closed

Aborted render should mark render pass as converged #4

nrusch opened this issue Nov 12, 2019 · 0 comments · Fixed by #309
Assignees
Labels
enhancement New feature or request render delegate Related to the Arnold Render Delegate user Reported by a user

Comments

@nrusch
Copy link
Contributor

nrusch commented Nov 12, 2019

Currently, performing a blocking Hydra render to completion requires a pattern similar to the following:

auto tasks = taskController->GetRenderingTasks();
do {
    engine.Execute(renderIndex, &tasks);
}
while (!taskController->IsConverged());

Right now, if the render performed by HdArnoldRenderPass aborts for any reason, the render pass is not marked as converged, and thus the above code will block indefinitely.

I think the most "correct" thing to do in the case of an Arnold render error is to mark the pass as converged and zero the render pass' output buffers.

@Autodesk Autodesk deleted a comment from kikou Nov 15, 2019
@sirpalee sirpalee added the render delegate Related to the Arnold Render Delegate label Nov 29, 2019
@sirpalee sirpalee changed the title [render delegate] Aborted render should mark render pass as converged Aborted render should mark render pass as converged Nov 29, 2019
@kikou kikou added this to To do in sprint13 via automation Dec 6, 2019
@kikou kikou removed this from To do in sprint13 Dec 6, 2019
@kikou kikou added this to To do in sprint14 via automation Dec 6, 2019
@kikou kikou added this to To do in sprint15 Dec 20, 2019
@sirpalee sirpalee added this to To do in Sprint 16 via automation Jan 10, 2020
@sirpalee sirpalee removed this from To do in sprint15 Jan 10, 2020
@sirpalee sirpalee added the enhancement New feature or request label Jan 11, 2020
@sirpalee sirpalee self-assigned this Jan 11, 2020
@sirpalee sirpalee removed this from To do in Sprint 16 Jan 24, 2020
@sirpalee sirpalee added this to To do in Sprint 17 via automation Jan 24, 2020
@sirpalee sirpalee removed this from To do in Sprint 17 Feb 6, 2020
@sirpalee sirpalee added this to To do in Sprint 18 via automation Feb 6, 2020
@sirpalee sirpalee added this to To do in Sprint 17 via automation Feb 6, 2020
@compso compso added this to To do in Sprint 19 via automation Feb 21, 2020
@compso compso removed this from To do in Sprint 18 Feb 21, 2020
@compso compso removed this from To do in Sprint 19 Mar 6, 2020
@compso compso added this to To do in Sprint 20 via automation Mar 6, 2020
@sirpalee sirpalee moved this from To do to In progress in Sprint 20 Mar 20, 2020
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 27, 2020
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 27, 2020
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 27, 2020
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 27, 2020
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 27, 2020
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 27, 2020
@kikou kikou added this to In progress in Sprint 21 Mar 27, 2020
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 29, 2020
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 29, 2020
sirpalee added a commit to sirpalee/arnold-usd that referenced this issue Mar 30, 2020
Sprint 21 automation moved this from In progress to Done Mar 30, 2020
@sirpalee sirpalee added the user Reported by a user label May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request render delegate Related to the Arnold Render Delegate user Reported by a user
Projects
No open projects
Sprint 17
  
To do
Sprint 20
  
In progress
Sprint 21
  
Done
sprint14
  
To do
Development

Successfully merging a pull request may close this issue.

2 participants